Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense activating inside of strings #5051

Closed
v-codeel opened this issue Apr 6, 2016 · 7 comments
Closed

Intellisense activating inside of strings #5051

v-codeel opened this issue Apr 6, 2016 · 7 comments
Assignees
Labels
*as-designed Described behavior is as designed javascript JavaScript support issues

Comments

@v-codeel
Copy link

v-codeel commented Apr 6, 2016

  • VSCode Version: 0.10.11
  • OS Version: Windows 10

(Code examples will be in C#, but also repro's with other languages)

Scenario 1 Repro:

  1. var x = "%%
  2. With the cursor at %%, Type C
  3. Code Completion suggestions are shown.
    image

Scenario 2 Repro:

  1. Console.WriteLine("%%)
  2. Intellisense will be showing. Click elsewhere in the file to dismiss it.
  3. Type (
  4. Intellisense is shown again.
    image
    (This would be normal if it hadn't been previously dismissed.)
@v-codeel
Copy link
Author

v-codeel commented Apr 6, 2016

Repro's on OSX as well.

@DustinCampbell
Copy link
Member

Both are great bugs -- could you please file over in https://github.com/omnisharp/omnisharp-vscode/issues rather than on VS Code itself?

@v-codeel
Copy link
Author

v-codeel commented Apr 6, 2016

Migrated to dotnet/vscode-csharp#154, but leaving this open since it repro's with languages other than C# (specifically tested with JavaScript)

@joaomoreno
Copy link
Member

Forwarding to @dbaeumer due to

specifically tested with JavaScript

@dbaeumer dbaeumer added javascript JavaScript support issues info-needed Issue requires more information from poster labels Apr 7, 2016
@dbaeumer
Copy link
Member

dbaeumer commented Apr 7, 2016

@v-codeel we always include textual completions in code complete (e.g words that are in the document). We find this useful in strings and comments. Are you proposing not to show them? They are marked with an icon 'abc' to indicate that they are textual completions only.

@v-codeel
Copy link
Author

v-codeel commented Apr 7, 2016

@dbaeumer I thought it was odd since this doesn't happen in the normal VS product. I didn't notice the 'abc' icons previously, but I guess it makes sense.
Having the snippets seems odd to me, but based on the resolution of #5069, I suppose the answer would be to leave those as well.

@mjbvz mjbvz self-assigned this Jan 26, 2017
@mjbvz mjbvz added *as-designed Described behavior is as designed and removed info-needed Issue requires more information from poster labels Jan 26, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 26, 2017

Closing as this is by design. I only see word based and snippet suggestions inside of string in JS

It sounds like snipped completions are expected and you can also disable word base suggestions entirely if this behavior is annoying

@mjbvz mjbvz closed this as completed Jan 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed javascript JavaScript support issues
Projects
None yet
Development

No branches or pull requests

5 participants