Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter/search box api support to custom tree views #50062

Closed
eamodio opened this issue May 17, 2018 · 20 comments
Closed

Add filter/search box api support to custom tree views #50062

eamodio opened this issue May 17, 2018 · 20 comments
Assignees
Labels
api feature-request Request for new features or functionality on-testplan tree-views Extension tree view issues
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented May 17, 2018

It would be great for an extension to provide the same filter/search box support that the new Outline view supports. Searching and filter custom views is a request I'm hearing more and more with GitLens.

/cc @jrieken

@Gruntfuggly
Copy link

Gruntfuggly commented Jul 16, 2018

This would be great, but it doesn't necessarily need to just be filter/search. There are other inputs which would be usefully located in the tree view - renaming, for example, so it would be cool if the API can be fairly generic...

@ntotten
Copy link

ntotten commented Sep 17, 2018

This would be helpful for us on the salesforce test explorer as well. https://github.com/forcedotcom/salesforcedx-vscode/issues/605

I agree the functionality should be generic. Allow extensions to add custom UI to the view's toolbar.

@ntotten
Copy link

ntotten commented Jan 10, 2019

We have another need for this in the Salesforce Extensions: forcedotcom/salesforcedx-vscode#862

@chnliquan
Copy link

does the custom treeProvider will provide a filter/search box? I think this requirement is very necessary, otherwise it is difficult to find the data you want in the case of a lot of data.
Is it possible to open the outline search box and filter it through the label property of the tree node?image
@sandy081

@sandy081
Copy link
Member

Might not be as an API but we are looking to implement a generic filtering for all trees which will just filter the data that is visible.

@chnliquan
Copy link

Might not be as an API but we are looking to implement a generic filtering for all trees which will just filter the data that is visible.

thanks, looking forward to the implementation of the function, where can I get notice if the implementation is complete?

@cawoodm
Copy link

cawoodm commented Mar 22, 2019

Is there any way to filter the explorer view today?
image

@mtxr
Copy link

mtxr commented Apr 10, 2019

I don't think so.

I'm looking forward to it as well.

@connorshea
Copy link
Contributor

This'd be very useful 🙇

@superfliege
Copy link

any update on this?

@mtxr
Copy link

mtxr commented Jun 7, 2019

I'm looking forward to see it as well

@alekkowalczyk
Copy link

Coming from here hbenl/vscode-test-explorer#4
Would be really usefull and make the VSCode experience a step closed to the full VS :)

@eamodio
Copy link
Contributor Author

eamodio commented Jul 11, 2019

Now that #63566 has landed, hopefully this can be supported!

@sandy081 sandy081 modified the milestones: Backlog, July 2019 Jul 12, 2019
@sandy081
Copy link
Member

With new Tree, custom views can be filtered just like file explorer.

@usernamehw
Copy link
Contributor

It doesn't search in nested folders which makes this mildly useless and inconsistent ... and it's not an API ... and not a real input. Not hating, just stating.

@sandy081
Copy link
Member

It is consistent with other trees (file explorer). Exposing as an API is a big ASK which I am afraid might not happen soon.

@sandy081
Copy link
Member

Closing this as the custom views with new tree supports filtering

@sandy081 sandy081 removed their assignment Jul 22, 2019
@Freshchris01
Copy link

@sandy081 Is this feature somewhere documented? Couldn't find it..

@sandy081
Copy link
Member

@alexr00 Is it documented in 1.37 release notes?

@alexr00
Copy link
Member

alexr00 commented Aug 14, 2019

It's called out here which links to more info and includes documentation about the Improved Keyboard Navigation.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality on-testplan tree-views Extension tree view issues
Projects
None yet
Development

No branches or pull requests