Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console.log in Webview client script should not pollute the main DevTool #48717

Closed
octref opened this issue Apr 25, 2018 · 1 comment
Closed

console.log in Webview client script should not pollute the main DevTool #48717

octref opened this issue Apr 25, 2018 · 1 comment
Assignees
@mjbvz
Labels
*as-designed Described behavior is as designed webview Webview issues

Comments

@octref
Copy link
Contributor

octref commented Apr 25, 2018

#48453

Imagine user installs a few chatty Webview extensions. This will bury all meaningful logs in dev tools.

image
@octref octref added the webview Webview issues label Apr 25, 2018
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Apr 26, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 26, 2018

This is consistent with what we do if an extension itself calls console.log. I personally find the behavior useful because it lets me just run the the main VS Code developer tools to see log message and errors that happen in any webview. Launching inspectors for each webview individually can be tedious

@mjbvz mjbvz closed this as completed Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*as-designed Described behavior is as designed webview Webview issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@octref @mjbvz