Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retainContextWhenHidden should restore focus within the webview as well #48604

Closed
Tyriar opened this issue Apr 24, 2018 · 2 comments
Closed

retainContextWhenHidden should restore focus within the webview as well #48604

Tyriar opened this issue Apr 24, 2018 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code webview Webview issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 24, 2018

#48453

Repro:

Create a webview with retainContextWhenHidden: true containing an <input>. Open the webview, add text to the webview and select it. Press ctrl+tab twice, notice the selection is there but the focus is not.

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues feature-request Request for new features or functionality labels Apr 25, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 18, 2018

Focus should also be restored when just switching back to a visible webview from another editor group

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 18, 2019

As I thought about this more, I think we should leave this up to extensions actually. They have a much better understanding of how focus should be restored. I'm worried that existing extensions may already implement their own logic or that we would get the focus restoration wrong.

I'll open issues against the github PR extension to implement focus restoration

@mjbvz mjbvz closed this as completed Mar 18, 2019
@mjbvz mjbvz added the *out-of-scope Posted issue is not in scope of VS Code label Mar 18, 2019
@mjbvz mjbvz removed the bug Issue identified by VS Code Team member as probable bug label Mar 18, 2019
@weinand weinand removed this from the March 2019 milestone Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code webview Webview issues
Projects
None yet
Development

No branches or pull requests

3 participants