-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define compatible platform for extensions #4801
Comments
A problem I can see with this is that it could encourage to take the easy way out. Given most extensions probably start out as a tool someone needs for their personal use, I could already see my lazy self: "Hmm, this will probably run on Windows just fine, but I should test it first." Now testing it will require me to reboot my computer, but because I am a lazy person I just mark the extension as incompatible and be done with it. It already does everything I personally need it to do after all. Since Windows users do not even see the extension, there is little chance for a PR to come in, or even just a comment like "it works without problems, just mark it as compatible". Not saying I can't see your point of view, just there is the potential of such a thing ending up being harmful to the extension ecosystem. |
I understand your point, but I think that the same way that a lazy developer could choose the easier path and activate and extension only for selected platforms, he/she could publish an unfinished extension with known issues, and maybe, never fix it. At least being able to define compatible platforms, it prevents the users from installing extensions that will not work. |
@modigrv Is there any such concept? Maybe accessible through version properties, which vsce would properly map from our |
Sent the request to Marketplace PM. |
We don't have support for adding platform dependency in the manifest on Marketplace. Primarily because the current thinking is the extension should ideally be supported on all platforms that the product is supported. But yes I have seen a few instances of where an extension is supported only on particular platforms. Will work with @waderyan to see what can be done here. |
This would be useful, I made some extensions that interact with apps that are macOS-only (like Finder), there's no point in installing said extensions for a non-macOS user. Currently if an extension defines a keybinding for mac, one for non-mac systems must be provided as well, which doesn't make sense in these scenarios. |
Another example of stuff like native modules only being required on particular platforms in fsevents https://github.com/strongloop/fsevents/blob/master/binding.gyp#L6 |
We have platform specific extensions thus closing this as done |
It would be interesting to be able to define the platforms (Windows, Linux, Mac) that an extension is compatible, and then, be filtered in
Command Palette
, to present only the compatibles.Sometimes the extension is developed explicit for specific platforms, and sometimes it is not ready (yet) for all platforms, or present temporary issues, and could be turned off until it is fixed.
Thanks in advance
The text was updated successfully, but these errors were encountered: