Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Size Terminal Control #46191

Closed
IlyaBiryukov opened this issue Mar 20, 2018 · 1 comment
Closed

Fixed Size Terminal Control #46191

IlyaBiryukov opened this issue Mar 20, 2018 · 1 comment
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@IlyaBiryukov
Copy link

Issue Type: Feature Request

Fixed size terminal control

VS Code version: Code - Insiders 1.21.0-insider (9a04587, 2018-03-01T08:09:20.917Z)
OS version: Windows_NT x64 10.0.16299

Today integrated terminal auto-fits the window and changes its cols count when user resizes the window. Our extension needs to be able to start a terminal with the fixed column count which we would specify on terminal creation, and which won't change when the terminal window resizes.

This could be achieved by adding rows?: number | undefined member to vscode.TerminalOptions.
The behavior may be that if this rows is set, the terminal control has fixed width. When terminal window is wider than the terminal control with fixed width, the the empty space is filled with background color. When the terminal window is smaller, we can either clip the control, or show a horizontal scroll bar.

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Mar 20, 2018
@Tyriar Tyriar added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 20, 2018
@Tyriar Tyriar added the api label Mar 20, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 22, 2018

This is captured in the API for #46192

@Tyriar Tyriar closed this as completed Jun 22, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 22, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants