Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet slow in large files #45747

Closed
SaniJasi opened this issue Mar 14, 2018 · 8 comments
Closed

Emmet slow in large files #45747

SaniJasi opened this issue Mar 14, 2018 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@SaniJasi
Copy link

SaniJasi commented Mar 14, 2018

I have a project on Shopify. And for developing I use files like this styles.scss.liquid.
And emmet working bad...
For example, I want to create font-size: 20px;
I use fz20 and press tab, but emmet generates font-size: 2px; but i need font-size: 20px;
And emmet working slow, please look this video: http://take.ms/kxnE

  • VSCode Version: Latest
  • OS Version: MacOS

Steps to Reproduce:

  1. fz20 -> font-size: 2px; (this bug in all files scss, sass, less, css)
  2. http://take.ms/kxnE

Does this issue occur when all extensions are disabled?: No

@vscodebot vscodebot bot added the emmet Emmet related issues label Mar 14, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 14, 2018

In your video, fz20 gets expanded to font-size: 20px and not font-size: 2px.
The slowness is due to the large size of your file. In the video, you have already crossed 10000 lines.
Do you see slowness in smaller files too?

The slowness of emmet in large files is being tracked in #43470

@SaniJasi
Copy link
Author

SaniJasi commented Mar 14, 2018

In my video, i recorded only slowness

Do you see slowness in smaller files too?
No

@ramya-rao-a
Copy link
Contributor

Can you share a video that shows fz20 expanding to font-size: 2px ?

@ramya-rao-a ramya-rao-a added the info-needed Issue requires more information from poster label Mar 15, 2018
@SaniJasi
Copy link
Author

http://take.ms/wIbDE you can see this bug also in this issue #38493

@ramya-rao-a
Copy link
Contributor

Looks like at second 8, we have w10

image

You add the next 0 and you hit tab to select the completion item before the auto-completion gets updated (because it is slow)

Fixing the slowness will fix this as well.

@ramya-rao-a
Copy link
Contributor

Will close this issue in favor of #43470

@ramya-rao-a ramya-rao-a reopened this Mar 24, 2018
@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 24, 2018
@ramya-rao-a ramya-rao-a added this to the March 2018 milestone Mar 24, 2018
@ramya-rao-a ramya-rao-a changed the title Emmet slow working if i use liquid template Emmet slow in large files Mar 24, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 27, 2018

@SaniJasi This is fixed with 91416ff and the fix will be available in tomorrow's Insiders build.

Note to verifier:

  • In a large css file (try more than 10k lines), type fz2
  • Once completions show font-size: 2px, quickly type 0 and then tab
  • In Stable (1.21), you will see font-size: 2px; and in Insiders (1.22) you should see font-size: 20px;

@SaniJasi
Copy link
Author

Great news! Thank you

@rebornix rebornix added the verified Verification succeeded label Mar 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants