Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot go to implementation source of node module dependency from Windows #45215

Closed
randomcatgamer opened this issue Mar 7, 2018 · 1 comment
Assignees
Labels
javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@randomcatgamer
Copy link

randomcatgamer commented Mar 7, 2018

  • VSCode Version: 1.20.1 & 1.21.0 insider
  • OS Version: Windows 10 Pro x64

Steps to Reproduce:

  1. Load a NodeJs Project
  2. Go a Source file having a npm dependency for example require('kafka-node');...
  3. Go to Definition and notice it is a typed definition // Type definitions for kafka-node 2.0... and not the source that you want to look into
  4. Go to Type Definition and notice it is the same thing
  5. Go to your colleague's Mac running Visual Code 1.20.1 and notice that for the same project, same statement, same default configuration, for steps 3 and 4 it goes to the actual source exports.HighLevelConsumer = require(‘./lib/highLevelConsumer’);.... Why for his case there is not TypedDefinition at all seems also quite strange

Why is this happening? I tried cleaning the installations and trying again. I looked and looked for anyone else having this issue, but to no avail. I would really want to use Visual Code, but this is a very bothersome issue. Please help

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added insiders and removed insiders labels Mar 7, 2018
@kieferrm kieferrm added the javascript JavaScript support issues label Mar 7, 2018
@mjbvz mjbvz added info-needed Issue requires more information from poster upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels Mar 26, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 26, 2018

Sorry, this issue feel off my radar

Opening a d.ts is generally the expected behavior for node_modules. We use these d.ts to provide intellisense without having to try to parse the module's code itself.

There are a few issues already tracking a better story for this:

Closing as upstream

@mjbvz mjbvz closed this as completed Mar 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants