Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path completion: completing a folder should retrigger code completion #44815

Closed
aeschli opened this issue Mar 1, 2018 · 4 comments
Closed

path completion: completing a folder should retrigger code completion #44815

aeschli opened this issue Mar 1, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 1, 2018

Testing #44460

Version 1.21.0-insider
Commit 9a04587
Date 2018-03-01T06:47:39.037Z

  • create foo.html, bar.html in a folder 'a/b/c'
  • in `foo.html' have
<a href="../../../"

and do code completion after /.

  • pick a
  • this should result in <a href="../a/" (slash at the end) and reopen code completion again so that the user can continue completing
@aeschli aeschli added html HTML support issues feature-request Request for new features or functionality labels Mar 1, 2018
@octref octref added this to the March 2018 milestone Mar 1, 2018
@octref
Copy link
Contributor

octref commented Mar 1, 2018

I was modeling after TS's path complete, but I guess for html it's a bit different since you can import from folder and it defaults to index.js, and there is no such behavior in html.

@aeschli
Copy link
Contributor Author

aeschli commented Mar 2, 2018

A folder path is also valid in HTML (once navigated there, it's up to the web server to decide what to return), but I'd think it's the less common case and it users would rather continue to enter a path.

@octref octref modified the milestones: March 2018, Backlog Mar 8, 2018
@octref
Copy link
Contributor

octref commented Mar 8, 2018

I would want to hear more people's feedback before doing this. Current behavior is in-line with TS and the two most popular path completion extensions:

https://marketplace.visualstudio.com/items?itemName=christian-kohler.path-intellisense
https://marketplace.visualstudio.com/items?itemName=ionutvmi.path-autocomplete

@aeschli
Copy link
Contributor Author

aeschli commented Mar 9, 2018

Think of the many keystokes necessary to enter a path like aaa/bbb/foo.html

a, ctrl+space (code assist), enter to select aaa, /, b, ctrl+space, enter to select bbb, /, f, ctrl+space, enter to select foo.html

That's 11 keystrokes to enter a path, almost as long as the path itself!

With the suggested change: 5 keystrokes

  • a, ctrl+space (code assist), enter select aaa, enter select bbb, enter select foo.html

To complete 'aaa/bbb' : 5 keystrokes

  • a, ctrl+space (code assist), enter select aaa, enter select bbb, escape to close code assist window

Let's be better than the extensions.
Also, it's what we do when completing HTML properties:
Try <input t| pick type

@octref octref modified the milestones: Backlog, March 2018 Mar 9, 2018
@octref octref closed this as completed in c681888 Mar 10, 2018
@octref octref added the bug Issue identified by VS Code Team member as probable bug label Mar 10, 2018
@aeschli aeschli removed the feature-request Request for new features or functionality label Mar 27, 2018
@mjbvz mjbvz added the verified Verification succeeded label Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants