-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Open in Terminal" not working on Fedora #4478
Comments
Reproduced. It gives the error |
|
There is a PR #3495 that allows Linux users to specify a different terminal other than the hard coded |
@pflannery thanks for pointing that out |
Great thanks @Tyriar and @pflannery |
#3495 fixes this issue, thanks again @pflannery |
On my freshly installed Fedora 23 install I get the same error as above. That's with VSCode 1.0.1 (April release). Reopening... |
I'm on the latest build from today that we use for testing
Is there anything I need to install or configure first? |
The code for that is here https://github.com/Microsoft/vscode/blob/849abd65ebf3e8c0f807e05639e723d16f8e6e3a/src/vs/workbench/parts/execution/electron-browser/terminal.ts#L9, it should yield gnome-terminal if it uses gnome (not sure if Fedora has other flavors). I created this to improve the defaults later though I expect it to work #5780 |
Closing in favor of #5780 |
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: