Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open in Terminal" not working on Fedora #4478

Closed
Coder206 opened this issue Mar 20, 2016 · 11 comments
Closed

"Open in Terminal" not working on Fedora #4478

Coder206 opened this issue Mar 20, 2016 · 11 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux verified Verification succeeded
Milestone

Comments

@Coder206
Copy link

  • VSCode Version: 0.10.11
  • OS Version: Fedora 23 (64 Bit)

Steps to Reproduce:

  1. Save work
  2. Right click in the toolbar
  3. Select "Open in Terminal"
@Tyriar Tyriar self-assigned this Mar 20, 2016
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux labels Mar 20, 2016
@Tyriar
Copy link
Member

Tyriar commented Mar 20, 2016

Reproduced. It gives the error spawn ENOTDIP. It's happening because x-terminal-emulator is not in the PATH on Fedora.

@Tyriar
Copy link
Member

Tyriar commented Mar 20, 2016

x-terminal-emulator is part of the Debian alternatives system which is why this doesn't work.

@pflannery
Copy link

There is a PR #3495 that allows Linux users to specify a different terminal other than the hard coded x-terminal-emulator not sure whether it will be accepted or not though

@Tyriar
Copy link
Member

Tyriar commented Mar 21, 2016

@pflannery thanks for pointing that out

@Coder206
Copy link
Author

Great thanks @Tyriar and @pflannery

@Tyriar Tyriar added this to the April 2016 milestone Apr 18, 2016
@Tyriar Tyriar changed the title "Open in Terminal" not loading terminal "Open in Terminal" not working on Fedora Apr 18, 2016
@Tyriar
Copy link
Member

Tyriar commented Apr 18, 2016

#3495 fixes this issue, thanks again @pflannery

@aeschli
Copy link
Contributor

aeschli commented Apr 26, 2016

On my freshly installed Fedora 23 install I get the same error as above. That's with VSCode 1.0.1 (April release). Reopening...

@aeschli aeschli reopened this Apr 26, 2016
@pflannery
Copy link

Just did a fresh install of fedora 23 and it works for me.
Did you have a workspace open?

This is the vscode version I tested with

image

@aeschli
Copy link
Contributor

aeschli commented Apr 26, 2016

I'm on the latest build from today that we use for testing
The dev tools console shows: shell.ts:415spawn x-terminal-emulator ENOENT: Error: spawn x-terminal-emulator ENOENT.

[aeschli@localhost workspaces]$ which x-terminal-emulator 
/usr/bin/which: no x-terminal-emulator in (/bin:/usr/bin:/usr/local/bin:/usr/local/sbin:/usr/sbin:/home/aeschli/.local/bin:/home/aeschli/bin)

Is there anything I need to install or configure first?

@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2016

The code for that is here https://github.com/Microsoft/vscode/blob/849abd65ebf3e8c0f807e05639e723d16f8e6e3a/src/vs/workbench/parts/execution/electron-browser/terminal.ts#L9, it should yield gnome-terminal if it uses gnome (not sure if Fedora has other flavors).

I created this to improve the defaults later though I expect it to work #5780

@aeschli aeschli modified the milestones: May 2016, April 2016 Apr 29, 2016
@Tyriar
Copy link
Member

Tyriar commented May 14, 2016

Closing in favor of #5780

@Tyriar Tyriar closed this as completed May 14, 2016
@Tyriar Tyriar added the verified Verification succeeded label May 23, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants