Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centered mode should hide the title area #44593

Open
isidorn opened this issue Feb 27, 2018 · 13 comments
Open

Centered mode should hide the title area #44593

isidorn opened this issue Feb 27, 2018 · 13 comments
Assignees
Labels
feature-request Request for new features or functionality workbench-zen Full screen 'Zen' view issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2018

The title area is noise and should die

fyi @joaomoreno

@isidorn isidorn added feature-request Request for new features or functionality layout General VS Code workbench layout issues labels Feb 27, 2018
@isidorn isidorn added this to the March 2018 milestone Feb 27, 2018
@isidorn isidorn self-assigned this Feb 27, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Mar 1, 2018

The question is what to do if tabs are enabled. I say not hide. So only if tabs are not shown we hide the title area. ZenMode by default hidesTabs so I think it will behave nicely

@joaomoreno
Copy link
Member

joaomoreno commented Mar 1, 2018

Here's what I think about tabs: they should take 100% of the workbench width. You might need a border-bottom line to make it look good. But IMO, only the editor itself should be of reduced width. Give it a try.

@isidorn
Copy link
Contributor Author

isidorn commented Mar 5, 2018

@joaomoreno if tabs are shown they take 100% of width so we are good.
@bpasero I looked at what it would mean for the editorGroupsControl to handle the fact that there is no titleControl, basically all code would need to handle the case that getTitleAreaControl can return undefined.
Also I would change this to be a getter.
Just mentioning in which direction I plan to go so fyi

@isidorn
Copy link
Contributor Author

isidorn commented Mar 19, 2018

Will not have cycles this milestone -> pushing to On Deck

@vidhanio
Copy link

vidhanio commented Aug 9, 2021

Could someone take a look at this feature again? It would be greatly appreciated! :)

@isidorn isidorn assigned JacksonKearl and unassigned isidorn Aug 16, 2021
@isidorn isidorn modified the milestones: On Deck, Backlog Aug 16, 2021
@reissbaker
Copy link

Would love this feature as well; it doesn't feel very distraction-free with the tab bar + a prominent dropshadow (which appears whenever you scroll down). It's also just pure noise if the tab bar is disabled, as it is by default in Zen Mode: it shows you the current tab filename, which you presumably already know, but not any other filenames — so what's the point?

Would also love to have the outline ruler disabled in Zen Mode, or at least have the option to disable it, but baby steps 😝 I just disable the outline ruler entirely anyway, 100% of the time (whether in Zen Mode or not), by setting vertical scrollbar width to 0.

@lrnv
Copy link

lrnv commented Feb 28, 2022

One more bump for a really needed feature. There should be an option to remove it, since it takes up screen real estate, vertical screen real estate, which is very important on e.g. 14" laptops

@AleksandrovC
Copy link

the feature was already created - but sadly not implemented 😓

[https://github.com//pull/117149/commits/90480c27bc19ba90b8f6e29b0f24215896a08cfc]

@lramos15 lramos15 assigned sbatten and unassigned JacksonKearl May 25, 2022
@narqo
Copy link

narqo commented Jun 27, 2022

I'd rather had this feature as a toggle in the Appearance settings, rather than something bound to a particular layout mode. As it's been pointed out above, if the user switched tabs off in the settings, it was likely, they expected to recycle extra vertical space on the screen.

@ultraGentle
Copy link
Contributor

a prominent dropshadow (which appears whenever you scroll down)

Just wanted to highlight this from an earlier post -- the drop shadow that appears on scroll can be quite prominent and distracting depending on the theme. It would indeed be nice to have Zen mode eliminate this along with any titlebar/tabs.

@Jonatan-r
Copy link

Yup. Please make this work <3

@matjazbrilj
Copy link

Is this feature implemented yet?

@Zelmoghazy
Copy link

5 years later, please implement this

@sbatten sbatten assigned benibenj and unassigned sbatten Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality workbench-zen Full screen 'Zen' view issues
Projects
None yet
Development

No branches or pull requests