Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing search.location doesn't remember icon position in activity bar #44306

Closed
usernamehw opened this issue Feb 23, 2018 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@usernamehw
Copy link
Contributor

#9435

@vscodebot vscodebot bot added the search Search widget and operation issues label Feb 23, 2018
@roblourens roblourens assigned isidorn and unassigned roblourens Feb 24, 2018
@isidorn isidorn added this to the March 2018 milestone Feb 26, 2018
@isidorn isidorn closed this as completed in e929a1c Mar 8, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 8, 2018

Thanks for reporting this.
I did not want to store the previous position as that would require an additional array to be stored in storage and would overcomplicate things. Instead I decided to respect the order when a composite is added to the composite bar. In practice this means that wehn the search is returned to the activity bar it will got to the second position. And when ti is placed in hte panel it will go to the first since it has the lowest order.

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Mar 30, 2018
@rebornix rebornix added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants