Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git does not appear to be working #38427

Closed
TynesideGroup opened this issue Nov 15, 2017 · 9 comments
Closed

Git does not appear to be working #38427

TynesideGroup opened this issue Nov 15, 2017 · 9 comments
Assignees
Labels
git GIT issues

Comments

@TynesideGroup
Copy link

  • VSCode Version: Code - Insiders 1.19.0-insider (73830a3, 2017-11-13T15:41:17.934Z)
  • OS Version: Windows_NT x64 10.0.15063

Steps to Reproduce:

  1. Open any project in which Git has been initialised (i.e. project has a valid .git folder)
  2. Open Source Control panel (Ctrl + Shift + G) and observe note "There are no active source control providers."
  3. Observe git status in integrated terminal works fine (in my case I am using integrated bash)
  4. Observe issue persists across multiple projects, so issue is not specific to a corrupted individual .git folder.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the insiders label Nov 15, 2017
@vscodebot vscodebot bot added the git GIT issues label Nov 15, 2017
@TynesideGroup
Copy link
Author

Just upgraded to the following version, the issue does not appear to be resolved:

Code - Insiders 1.19.0-insider (3a7d517, 2017-11-15T05:17:28.098Z)

@wangdachangchang
Copy link

@liam-potter I upgraded this version just now, but git does not appear,
VSCode Version : Code - Insiders 1.19.0-insider (3a7d517, 2017-11-15T05:17:28.098Z)
what should i do for this?

@TynesideGroup
Copy link
Author

@wangdachangchang My comment was that upgrading to that version did not resolve the issue.

I have upgraded to the following version this morning and Git appears to be working again:

(91a2020, 2017-11-16T05:17:48.036Z)

I will test this on my work machine (where Git was broken) tomorrow to confirm it is definitely fixed.

@joaomoreno
Copy link
Member

joaomoreno commented Nov 16, 2017

This happened because we no longer use Git from Github for Windows. You must install Git.

#38244 (comment)
#35965

@TynesideGroup
Copy link
Author

TynesideGroup commented Nov 17, 2017

I have never had Github for Windows installed on my work machine, only Git, and after arriving into the office this morning this issue persisted.

Reinstalling Git and updating git.path manually in my settings file fixed the issue for me. Git is installed in a non-standard location (an alternative hard drive) and as per your links the feature to read Git from PATH was disabled.

@joaomoreno
Copy link
Member

@liam-potter Got it. Can you do me a favor? Search in the registry for the path where git.exe is installed. Maybe if we can look into that registry value, we could detect where you have installed it.

@TynesideGroup
Copy link
Author

Sorry if I wasn't being clear, but the issue is resolved for me now that I have manually configured my git.path setting.

As requested I have looked in the registry but the only references to git.exe I could find were session-based values under Computer\HKEY_USERS\S-1-5-21-1119021569-3052555868-3407816479-1157\Software\Microsoft\RestartManager\Session0001. It has a RegFiles0000 key of REG_MULTI_SZ type and a list of various git-based dlls/exes. Not sure if that would be helpful?

@joaomoreno
Copy link
Member

joaomoreno commented Nov 17, 2017

I got it. I just wonder if we can detect an official Git for Windows installation, even when it's installed on another location, you know?

Hm those look almost what we need... I can also dig a bit.

@TynesideGroup
Copy link
Author

TynesideGroup commented Nov 17, 2017

Not sure if it is of any help, but on most modern Windows installations (probably Windows 7 or higher) you can run where git.exe or where git in command prompt to locate where it is installed. Perhaps looking into how where works would provide some pointers?

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

No branches or pull requests

3 participants