Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click some files cannot be opened from pending changes #36556

Closed
art-in opened this issue Oct 19, 2017 · 9 comments
Closed

Click some files cannot be opened from pending changes #36556

art-in opened this issue Oct 19, 2017 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Milestone

Comments

@art-in
Copy link

art-in commented Oct 19, 2017

  • VSCode Version: 1.17.1
  • OS Version: window 7

Steps to Reproduce:

  1. Upload some files to git
  2. Change them and try to see those changes from Source Control - pending changes tab

Some files cannot be opened, just ignored to open with left click or right click Open Changes.

  • can't say exactly what blocks them from opening. see no correlation in extension/previous contents/change/etc. Some files just cannot be opened. Have feeling it happens with 'index.js' files only, but not sure. [update: nope, experiencing same issue with other '.js' files too]

  • issue gets fixed after vs code reload.

demo:

gif

@vscodebot vscodebot bot added the workbench label Oct 19, 2017
@bpasero bpasero assigned joaomoreno and unassigned bpasero Oct 20, 2017
@rnemec
Copy link

rnemec commented Oct 20, 2017

This is really unpleasant. Any known workarounds?

@art-in
Copy link
Author

art-in commented Oct 21, 2017

@rnemec I'm restarting vs code as workaround

@rnemec
Copy link

rnemec commented Oct 21, 2017

Good old command-line resurrected: git difftool -d 😉

@joaomoreno joaomoreno added this to the October 2017 milestone Oct 27, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues scm General SCM compound issues and removed git GIT issues workbench labels Oct 27, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Nov 2, 2017

This seems very hard for me to reproduce. It's very possible that 9e9f809 fixed it. But not sure...

I'l close it for now. Please try the latest Insiders release or the upcoming November stable release (available next week) and let me know if you still see the issue.

@mjbvz mjbvz added the verified Verification succeeded label Nov 3, 2017
@joaomoreno joaomoreno changed the title some files cannot be opened from pending changes Click some files cannot be opened from pending changes Nov 6, 2017
@art-in
Copy link
Author

art-in commented Dec 3, 2017

still reproducible in v1.18.1
still cannot narrow repro, happens randomly 😢

@rnemec
Copy link

rnemec commented Dec 3, 2017

@joaomoreno - I can also confirm in 1.18.1. Please, consider re-opening this one. If there is anything we can do to help you collect some more info, let us know. Since it is not always reproducible, it must be something that we can have configured/turned on for longer time without making the env unusable.

@joaomoreno
Copy link
Member

joaomoreno commented Dec 4, 2017

@artin-phares @rnemec This is a duplicate of #35724 (comment) . It's fixed in Insiders.

@art-in
Copy link
Author

art-in commented Dec 4, 2017

@joaomoreno great! waiting for next stable v1.19.0

@rnemec
Copy link

rnemec commented Dec 4, 2017

Thank you, @joaomoreno !

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants