Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenDialogOptions: 'openFiles = false' lets me open files #35139

Closed
aeschli opened this issue Sep 26, 2017 · 2 comments
Closed

OpenDialogOptions: 'openFiles = false' lets me open files #35139

aeschli opened this issue Sep 26, 2017 · 2 comments
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s)

Comments

@aeschli
Copy link
Contributor

aeschli commented Sep 26, 2017

Testing #34821, Linux

  • Use yo code to create a sample extension and set extension.ts to
import * as vscode from 'vscode';
export function activate(context: vscode.ExtensionContext) {
    let disposable = vscode.commands.registerCommand('extension.sayHello', () => {
        vscode.window.showOpenDialog({
            openFiles: false,
            filters: {}
        }).then(r => console.log(r));
    });
    context.subscriptions.push(disposable);
}
  • run the 'sayHello' command
  • select a file and press ok
@vscodebot vscodebot bot added the api label Sep 26, 2017
@jrieken jrieken added this to the September 2017 milestone Sep 27, 2017
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Sep 27, 2017
@jrieken
Copy link
Member

jrieken commented Sep 27, 2017

@aeschli What would you expect? That is opens folder? The logic that if both are false, it will fallback to open files

@jrieken
Copy link
Member

jrieken commented Sep 27, 2017

closing this as duplicate of #35141

@jrieken jrieken closed this as completed Sep 27, 2017
@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants