Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showSaveDialog should have optional options #35053

Closed
joaomoreno opened this issue Sep 26, 2017 · 0 comments
Closed

showSaveDialog should have optional options #35053

joaomoreno opened this issue Sep 26, 2017 · 0 comments
Assignees
@jrieken
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2017

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Sep 26, 2017 •
edited
Loading

Testing #34821

Not passing options should be the same as:

showSaveDialog({ filters: {} });

Same for showOpenDialog.
@jrieken jrieken added api bug Issue identified by VS Code Team member as probable bug labels Sep 26, 2017
@jrieken jrieken added this to the September 2017 milestone Sep 26, 2017
@octref octref added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @octref