Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard accessibility: Strange behavior when focusing item after text editor #3373

Closed
Tyriar opened this issue Feb 23, 2016 · 3 comments
Closed

Keyboard accessibility: Strange behavior when focusing item after text editor #3373

Tyriar opened this issue Feb 23, 2016 · 3 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2016

#3246

When tab focus mode is on, doing the following:

  • Select text editor
  • Press tab
  • At this point I have no idea what is focused as I can't see anything on the UI with a border.
    • Pressing enter will add a new line where the cursor was, pressing enter again will not add another line
    • Pressing enter will add a new line, pressing backspace and enter will add another new line
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2016
@Tyriar Tyriar changed the title Strange behavior when keyboard accessibility focusing item after text editor Keyboard accessibility: Strange behavior when focusing item after text editor Feb 23, 2016
@alexdima alexdima added the info-needed Issue requires more information from poster label Feb 24, 2016
@alexdima
Copy link
Member

@Tyriar Can you please get the workbench in the same state as you had (the tab order is dependent on what you have opened) and open the developer tools and run this snippet:

setInterval(function() { console.log(document.activeElement); }, 1000);

This will print every second the DOM element where the focus is. We then need to figure out who owns that elements and why there's no focus indication on it.

@Tyriar
Copy link
Member Author

Tyriar commented Feb 24, 2016

It's focusing body:

<body class="monaco-shell vs-dark vscode-theme-colorful-defaults-themes-dark_plus-tmTheme">

Immediately after the textarea.

@alexdima
Copy link
Member

Duplicate of #2327

@alexdima alexdima added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @alexdima