Spawning git crashes extension host

[aman-manocha]

• VSCode Version: Code 1.15.1 (41abd21, 2017-08-16T18:07:25.676Z)
• OS Version: Windows_NT x64 10.0.15063
• Extensions: none

---

Steps to Reproduce:

1. Run visual studio code on Windows 10
2. Click on "reload" button results in same error again
3. Rebooting/re-install doesn't help

[alexdima]

@aman-manocha

Are you using the 64-bit version of VS Code or the 32-bit version ? Does this reproduce in both the 32-bit version and the 64-bit version ? Does this reproduce when running code --disable-extensions ?

When the error is shown, can you please open the Developer Tools (Help > Toggle Developer Tools) and check if there is any additional information in there?

[aman-manocha]

I am using 64-bit version of VS Code.
I didn't try 32-bit version.
I didn't install any extensions.
No additional information in Dev Tools

[Edmanbosch]

I also seem to keep getting this issue, it's weird since it used to never happen. It also seems to disappear when I remove the "git" folder from the install folder.

[alexdima]

@aman-manocha Can you consistently reproduce this? Even when opening a new empty window (i.e. File > New Window) ? or is it something reproducing only for a certain folder ?

[Edmanbosch]

Apparently, the reason why I got this error was because I didn't have git installed on my computer. After installing git it worked fine, even if I had the git folder inside my installation. If git is something required for VS Code, then it should be made a bit more obvious.

[joaomoreno]

This is very strange. @Edmanbosch let me ask you a favour: if you uninstall Git, does the issue start happening again?

[Edmanbosch]

So, I just uninstalled git, got the issue again. I installed git again and the issue was gone.

[joaomoreno]

Awesome! What's your exact OS?

[Edmanbosch]

Well, I'm using Windows 10.

[joaomoreno]

With exact, I meant the exact version number.

https://www.howtogeek.com/236195/how-to-find-out-which-build-and-version-of-windows-10-you-have/

[Z-starts]

@joaomoreno

installed git and the issue was gone.

[Edmanbosch]

@joaomoreno Ah, sorry. The version number is 1703, with the build number being 15063.608.

[joaomoreno]

@Edmanbosch @Z-starts @aman-manocha

I got something else to try. Uninstall git, make sure you still get the issue. Then, edit app/extensions/git/out/git.js (within VS Code's installation folder) and comment out the following line. It should be around line 82.

        .then(void 0, () => findSpecificGit('git'));

Does the issue still reproduce with that commented out?

[joaomoreno]

@alexandrudima I could confirm what you saw in Procmon. Consider the following code:

function findGitWin32(): Promise<IGit> {
	return findSystemGitWin32(process.env['ProgramW6432'])
		.then(void 0, () => findSystemGitWin32(process.env['ProgramFiles(x86)']))
		.then(void 0, () => findSystemGitWin32(process.env['ProgramFiles']))
		.then(void 0, () => findSpecificGit('git'));
}

When git is not installed, that code will trickle down to findSpecificGit('git') which will simply do cp.spawn('git'...). In my machine, I can see that Node loops through all the paths in %PATH% and appends git.com and git.exe to them and tries to spawn that.

It could be that in these user's machines this will spawn something other than git but called the same way, causing the crash.

I want to wait for a reply from @Edmanbosch @Z-starts @aman-manocha but my gut feeling tells me to simply delete that last fallback case. If users install git on a different path other than the default ones, we have the git.path setting for that. What do you think?

[Edmanbosch]

Just tried it out, and VS Code loads and gives me zero problems.

[joaomoreno]

That's awesome. How about this build? Still no problem?

[alexdima]

@joaomoreno Perhaps you could spawn where git and then check if there is a cmd\git.exe in the path ?

[joaomoreno]

@alexandrudima I'd actually be comfortable removing that find git wherever code altogether. That build I linked to in the previous commit does that. 👍

[Edmanbosch]

@joaomoreno That build works perfectly fine, even without having git installed.

[joaomoreno]

@aman-manocha Wanna give it a try?

[euk-anthonyb]

Same extension error occurs in the Insiders version. :(

[Tyriar]

Git installed for specific user is no longer picked up because of this change, see #40229