Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test omnisharp installation hint #2701

Closed
3 tasks done
jrieken opened this issue Feb 4, 2016 · 4 comments
Closed
3 tasks done

Test omnisharp installation hint #2701

jrieken opened this issue Feb 4, 2016 · 4 comments

Comments

@jrieken
Copy link
Member

jrieken commented Feb 4, 2016

Assignment

Details

We plan to make omnisharp an optional extension. To make a smooth transition we let the user know once and offer a direct install.

  • have no omnisharp installed
  • open vs code, open any csharp-ish resource (*.cs, project.json, *.csproj etc)
  • you are informed and offered to install

Make sure

  • that you get a reasonable hint
  • the hint only shows once (check local store for global://extensionsAssistant/legacy...)
  • you can install omnisharp from the hint
@jrieken jrieken added this to the Feb 2016 milestone Feb 4, 2016
@egamma
Copy link
Member

egamma commented Feb 9, 2016

The experience is bad without some progress indication, filed #2835

@egamma egamma mentioned this issue Feb 20, 2016
97 tasks
@stevencl
Copy link
Member

I agree with @egamma, while it works, the experience is pretty bad without any progress indication. But I also agree that we should take some time to think about how best to design a solution to this.

@chrisdias
Copy link
Member

The OmniSharp extension is being slimmed down to remove the runtime, such that the runtime will be installed on first activation. That means the extension should install quickly and then there will be UI to install the rest. @DustinCampbell is working on the install experience now.

@chrisdias
Copy link
Member

From my testing: The prompt is useful but it is easy to miss it and it never comes up again. Maybe I don’t want to install it right now, because I opened the tool on the wrong folder, etc. If I bring up the tool, get the prompt, and press Cmd+Q to exit Code I'll never get the prompt again.

I put a suggested experience in #2748, which is effectively to have a yes/no/later prompt and to only write the "do not prompt again" flag if the user presses "no".

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants