Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JavaScript] 'from' should have 'keyword.operator' scope #2694

Closed
Tyriar opened this issue Feb 4, 2016 · 3 comments
Closed

[JavaScript] 'from' should have 'keyword.operator' scope #2694

Tyriar opened this issue Feb 4, 2016 · 3 comments
Assignees
@aeschli
Labels
themes Color theme issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 4, 2016

The OceanicNext tmTheme (homepage) colors from as teal using the scope keyword.operator.

Created from #2684
@Tyriar Tyriar added the themes Color theme issues label Feb 4, 2016
@aeschli
Copy link
Contributor

aeschli commented Feb 4, 2016

I disagree here, keyword.operator is also often typically used for operators like '==', +, -...
We don't want to color these like keywords.

@aeschli aeschli closed this as completed Feb 4, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Feb 4, 2016

The main point is it does not even have keyword, I was going off import and export having the same scope. Maybe keyword.control would be best for both?

@Tyriar Tyriar mentioned this issue Feb 4, 2016
Closed
@aeschli
Copy link
Contributor

aeschli commented Feb 5, 2016

keyword.control sounds like a good choice!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
themes Color theme issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @aeschli