Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to implementation should navigate to .js file instead of typescript type definitions #26325

Closed
Wenzil opened this issue May 9, 2017 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality typescript Typescript support issues

Comments

@Wenzil
Copy link

Wenzil commented May 9, 2017

  • VSCode Version: 1.12.1
  • OS Version: OS X

Steps to Reproduce:

  1. Open VS Code in a new workspace
  2. npm init -y
  3. npm install --save express
  4. npm install --save-dev @types/express
  5. In tsconfig.json:
{
    "compilerOptions": {
        "target": "es6",
        "module": "commonjs",
        "allowJs": true,
        "checkJs": true,
        "noEmit": true,
        "maxNodeModuleJsDepth": 1
    },
    "exclude": [
        "node_modules"
    ]
}
  1. In index.js:
const express = require('express')
  1. Right click on 'express', and choose Go to implementation

Expected behaviour:

The editor navigates to the .js file containing the module implementation (under node_modules/express)

Actual behaviour:

The editor navigates to the installed express type definitions

@Wenzil
Copy link
Author

Wenzil commented May 9, 2017

Somewhat related to #26329

@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label May 10, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 10, 2017

Tracked upstream with microsoft/TypeScript#6209

@mjbvz mjbvz closed this as completed May 10, 2017
@mjbvz mjbvz added feature-request Request for new features or functionality typescript Typescript support issues labels May 10, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

2 participants