PHP IntelliSense extension - unable to edit files after selecting 'Go To Definition'

[GeorgeWells]

• VSCode Version: Code 1.11.1 (d9484d1, 2017-04-06T13:58:12.954Z)
• OS Version: Windows_NT ia32 6.1.7601
• Extensions:

Extension	Author	Version
githistory	donjayamanne	0.2.0
php-debug	felixfbecker	1.10.0
php-intellisense	felixfbecker	1.1.5
debugger-for-chrome	msjsdiag	2.7.3
gitblame	waderyan	1.3.0

---

Steps to Reproduce:

1. Right click a function and select 'Go To Definition'
2. The cursor doesn't blink and the file is not editable

This also happens if you select 'Peek Definition' and double click in the output to open the file.

[GeorgeWells]

No idea if this helps but when I 'Go To Definition' on a file which works I see this:

But for a file which doesn't work I see this:

Notice how it doesn't show the file encoding or the line ending format. Does it sound like it's failing some process of opening the file hence not working? This is the first time it has happened since I have raised this issue so it's quite hard to replicate.

[roblourens]

If you open the same file a different way, like through the file explorer, does this happen?

[GeorgeWells]

The workaround I have is to find the file in the explorer bar and open it.

[rebornix]

@GeorgeWells can you help check the debugger console to see if there is any error there when it happens? Help -> Toggle Developer Tools.

[GeorgeWells]

I'll have a look the next time it happens and let you know the results of the console.

I'm trying to see if I can replicate this issue again and again but may have come across a separate issue. If you switch git branch after the PHP Language Server parses (should it be parsing twice?) and this branch contains a new file with a class and another new file calling in the class and calling functions to it, you can't 'Go To Definition' on the functions to the class; it comes up with 'No definition found for xxx'. I'm guessing it's because it hasn't been parsed. After you've manually opened the file and closed it, it works.

[GeorgeWells]

Okay so it's just happened, I've captured the whole console so some errors may not be related. Hope this helps

[GeorgeWells]

I've cleared out the console and 'Go To Definition' on the function, it's opening the file in a read-only state but no errors are appearing in the console

[roblourens]

Yeah it looks like those errors are coming from emmet, and it has some issue with the grammar.

[jens1o]

cc @ramya-rao-a

[GeorgeWells]

Just happened again and checked the console, seeing different errors today. The below image is repeated on separate lines (14, 61, 129, 131, 132, 1331).

[jens1o]

Can you do a SHA-1 checksum of that file?

It should be 5F9CB7AFD681E6C7CECE2F3E15108E266E6D2860

When it is different to mine, try reinstalling the extension, then you might have corrupt data.

[GeorgeWells]

SHA-1 checksum comes out exactly the same:

F56B3864595701CD5C87AFE5248003247FEEFD9E

[jens1o]

Err, that's not the same checksum?

[GeorgeWells]

Reinstalled and got the same SHA-1 checksum as before:

F56B3864595701CD5C87AFE5248003247FEEFD9E

[jens1o]

Can you attach your file? It's really weird...

[GeorgeWells]

Had to zip it in order to upload it:

PhpTokenizer.zip

[jens1o]

Seems valid... I don't know... PHP binaries are fine?

[GeorgeWells]

I'm wondering if it's to do with the way I link up php.exe, I use the same one for both WAMP and PHP Intellisense at the same time:

Should I not be doing this?

[jens1o]

I think that should be fine. Sorry, but I don't know what happens there... 😭

[roblourens]

That error in PhpTokenizer is ok, it means that the tokenizer read a file with an unterminated comment, not that the file itself has an unterminated comment.

[jens1o]

Oh really? That musn't be true... Oh my gosh. Sorry. :/

[GeorgeWells]

I want to try to provide as much info as I can with this issue.

• This issue only exists if you use the 'PHP Intellisense' plugin due to needing the 'Go To Definition' and 'Peek Definition'

• This issue seems to only happen if you change git branches after the folder/repository has been parsed

• Sometimes when you 'Go To Definition' you get a message saying saying 'No definition found for...' but sometimes it will open the file in some sort of read-only state

• In this 'read-only' state, you are unable to edit the file, the cursor doesn't blink, there's no file path next to the file name

• If you leave it open and do nothing for a while, a popup appears saying 'The window is no longer responding', although you can close this and continue using it with no problems

• There are no errors/warnings appearing in the console

• Once you open the file manually and close it, 'Go To Definition' works as intended but having to open the file manually somewhat defeats the point of this

• I am using the latest version of VS Code and the PHP Intellisense plugin, using PHP 7.1.9

I'm guessing a potential fix to this could be to parse any new file that appears in the folder/repository i.e. when a git branch changes.

As always, if anyone wants me to check something or report anything then let me know.

[roblourens]

Thanks for the details, it seems most likely that the language server is doing something unexpected here. I'm not sure where to go from here, but I don't have evidence of a vscode bug.