Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome debugger: Would be nice to see location of console messages #24490

Closed
alexdima opened this issue Apr 11, 2017 · 9 comments
Closed

Chrome debugger: Would be nice to see location of console messages #24490

alexdima opened this issue Apr 11, 2017 · 9 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan release-notes Release notes issues

Comments

@alexdima
Copy link
Member

Testing #24403

It would be nice if we could show the file + line number when we print a console message in the debug console. I have found this to be a nice way to jump between relevant locations while debugging.

Expected:
image

Actual:
image

@isidorn
Copy link
Contributor

isidorn commented Apr 13, 2017

This first needs to be added to the debug protocl in order to be supported, assigning to @weinand

@isidorn isidorn assigned weinand and unassigned isidorn Apr 13, 2017
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Apr 13, 2017
@weinand
Copy link
Contributor

weinand commented Apr 13, 2017

The feature request for the DAP already exists: microsoft/vscode-debugadapter-node#94

@weinand weinand assigned isidorn and unassigned weinand Apr 13, 2017
@isidorn isidorn added this to the Mai 2017 milestone Apr 13, 2017
@isidorn
Copy link
Contributor

isidorn commented May 4, 2017

@roblourens can you estimate how much effort would it be to support this in the chrome debugger or node2? I am not sure if you just get it for free or how is chrome dev tools doing it?
I guess this estimate should influence how high we put this on the priority list for DAP changes

@roblourens
Copy link
Member

roblourens commented May 4, 2017

Every console message from the inspector debug protocol has an entire callstack attached - https://chromedevtools.github.io/devtools-protocol/v8/Runtime/#event-consoleAPICalled. I estimate... 20 minutes of work to implement microsoft/vscode-debugadapter-node#94 (comment) 😁

@isidorn
Copy link
Contributor

isidorn commented May 5, 2017

@roblourens great 😄
I missed Andre's question on that other issue

@isidorn
Copy link
Contributor

isidorn commented May 31, 2017

Let's move this out to June since it is dependent on microsoft/vscode-debugadapter-node#94 (comment) and we are in endgame

@isidorn isidorn modified the milestones: June 2017, May 2017 May 31, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2017

Moving this to 'On-Deck' until we plan to implement this

@isidorn
Copy link
Contributor

isidorn commented Sep 19, 2017

Currently this feature is not implemented neither by node or node2. In order to properly test this it would be great if one of the adapters would have the full implementation.
In the meantime I can try with some fake output messages.

fyi @roblourens created #34626 since node2 could support this

@alexdima
Copy link
Member Author

Nice!

@isidorn isidorn added the release-notes Release notes issues label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants