Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dvorak - QWERTY Keyboard Layout: In 1.11, keyboard shortcuts don't work as expected on Mac OS #23964

Closed
lambrossy opened this issue Apr 5, 2017 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone

Comments

@lambrossy
Copy link

  • VSCode Version: 1.11
  • OS Version: Mac OS Sierra 10.12.4 (16E195)

Steps to Reproduce:

  1. Set up Dvorak - QWERTY layout
  2. Use any keyboard binding
  3. Keybindings no longer revert to QWERTY layout as they should
@hampusborgos
Copy link

hampusborgos commented Apr 6, 2017

It appears the new key-rebinding feature when changing keyboard layout does not detect the Dvorak - Cmd-QWERTY layout correctly.

How do you downgrade to an older version of VS Code until this issue is resolved? Older version can be downloaded here: http://code.visualstudio.com/updates/v1_10

PS. The key rebinding feature is awesome. Nothing bad about that. :)

@mstange
Copy link

mstange commented Apr 6, 2017

The most painful one is Cmd+W: It opens the preferences instead of closing the tab. I am going to downgrade to v1.10 until this is resolved.

@alexdima
Copy link
Member

alexdima commented Apr 6, 2017

Workaround: switch VS Code to dispatch based on key code again. Add the following setting:
"keyboard.dispatch": "keyCode" and restart VS Code


I would really like to understand your setup. I'm sorry for the breakage, I am really trying to get this right. Could you please explain like I'm five how to get into your setup (I thought the whole point of dvorak is that its not qwerty -- the name contradicts itself, r cannot be both between o and a and betweer e and t), and what key combination fails. It would also help to attach here what our C++ node module detects (open an editor, press F1 > Developer: Inspect Keyboard Mappings save the output to a file and attach here).

@mstange
Copy link

mstange commented Apr 6, 2017

The keyboard layout is called "Dvorak - QWERTY ⌘". While the command key is pressed, it switches to the QWERTY layout, and otherwise it's the Dvorak layout.

Inspect Keyboard Mappings: https://gist.github.com/mstange/d739bfacecee8cbd6d46a89f7ce95f98

@alexdima
Copy link
Member

alexdima commented Apr 6, 2017

Thank you, that means we're busted. My assumptions were wrong :). The only workaround for now would be "keyboard.dispatch": "keyCode". Can you please confirm the workaround works for you?

@mstange
Copy link

mstange commented Apr 6, 2017

The workaround works for me. Thanks!

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X keyboard-layout Keyboard layout issues labels Apr 6, 2017
@gyzerok
Copy link
Contributor

gyzerok commented Apr 7, 2017

@alexandrudima the point of using this layout at least for me is the ability to preserve some commonly used hot keys as they are under QWERTY. For example Cmd + C and Cmd + W. So when you press Cmd your layout reverses to QWERTY and they just work.

@suederade
Copy link

You can also get around it by opening VSCode while having the standard keyboard selected. @gyzerok I do the same because then copy and paste becomes a two handed endeavor.

@xster
Copy link

xster commented Apr 8, 2017

@alexandrudima most of the common hot keys are also probably formulated with QWERTY in mind so ⌘C, ⌘V, ⌘W etc are all one handed instead of 2 handed

@alexdima alexdima added keybindings VS Code keybinding issues important Issue identified as high-priority labels Apr 10, 2017
@alexdima alexdima added this to the March Recovery 2017 (2) milestone Apr 10, 2017
@alexdima alexdima changed the title 1.11 keyboard shortcuts don't work as expected with Dvorak - QWERTY layout on Mac OS Dvorak - QWERTY Keyboard Layout: In 1.11, keyboard shortcuts don't work as expected on Mac OS Apr 10, 2017
@alexdima alexdima removed this from the March Recovery 2017 (2) milestone Apr 10, 2017
@alexdima alexdima removed the important Issue identified as high-priority label Apr 27, 2017
@alexdima alexdima added this to the April 2017 milestone Apr 27, 2017
@roblourens roblourens added the verified Verification succeeded label Apr 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants