Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find widget should close itself or adapt when the editor is too tiny #2338

Closed
alexdima opened this issue Jan 26, 2016 · 2 comments
Closed

Find widget should close itself or adapt when the editor is too tiny #2338

alexdima opened this issue Jan 26, 2016 · 2 comments
Assignees
@alexdima
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations verified Verification succeeded
Milestone
September 2016

Comments

@alexdima
Copy link
Member

Testing #2145

It is horrible (also not ok from an accessibility point of view):

image
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 26, 2016
@alexdima alexdima self-assigned this Jan 26, 2016
@alexdima alexdima mentioned this issue Jan 27, 2016
Closed
@alexdima alexdima added this to the Feb 2016 milestone Feb 2, 2016
@alexdima alexdima modified the milestones: March 2016, Feb 2016 Feb 22, 2016
@alexdima alexdima modified the milestones: April 2016, March 2016 Mar 17, 2016
@alexdima alexdima modified the milestones: April 2016, May 2016 Apr 28, 2016
@alexdima alexdima modified the milestones: Backlog, May 2016 May 25, 2016
@alexdima alexdima added the editor-find Editor find operations label Jun 26, 2016
@alexdima alexdima mentioned this issue Sep 1, 2016
Closed
This was referenced Sep 26, 2016
Closed
Closed
@alexdima alexdima modified the milestones: September 2016, Backlog Sep 26, 2016
@alexdima
Copy link
Member Author

find-widget-responsive

@bpasero
Copy link
Member

bpasero commented Sep 28, 2016

Very very nice 👍

@bpasero bpasero added the verified Verification succeeded label Sep 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations verified Verification succeeded
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
2 participants
@bpasero @alexdima