Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file icons similar to treeview item icon path in terminal icon path #233354

Open
karthiknadig opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@karthiknadig
Copy link
Member

In TreeViewItem, we can provide a resourceUri and ThemeIcon.File for iconPath to get file icons for the TreeViewItem. This should also work for Terminal Icon.

See discussions in issues:
#232439
For QuickPick: #59826

@Tyriar
Copy link
Member

Tyriar commented Nov 7, 2024

@karthiknadig do you have example extension code that could illustrate the ask?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Nov 7, 2024
@karthiknadig
Copy link
Member Author

For activated terminals, we want to show the icons for the file/python manager used to activate this terminal:
Image

For terminals, currently the only options is this. No way to get file icons. Can't really use the file path to get fileicons.
Image

For tree views I can do this:
Image

TreeView consumption example:
Image

I want to be able to use the same icon in terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants