Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding actions using display:none causes keyboard a11y issues #2329

Closed
alexdima opened this issue Jan 26, 2016 · 3 comments
Closed

Hiding actions using display:none causes keyboard a11y issues #2329

alexdima opened this issue Jan 26, 2016 · 3 comments
Assignees
@alexdima
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
Feb 2016

Comments

@alexdima
Copy link
Member

Testing #2145

In the working files:

  • tab until the last action
  • tab takes you to the file
  • tab takes you to the close file action <--- missed by shift-tab
  • tab takes you to the file/folder explorer

    Shift-tab should take you back to the close file action, instead it jumps straight to the file
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 26, 2016
@alexdima
Copy link
Member Author

The same is true for the actions in the file/folder explorer. The actions are only reachable via "Tab". They should be reachable via Shift-Tab as well

@alexdima
Copy link
Member Author

I think this is a problem with all "hidden" actions ?

@bpasero bpasero modified the milestone: Jan 2016 Jan 26, 2016
@bpasero bpasero changed the title Different focused elements when using Shift-Tab vs Tab Hiding actions using display:none causes keyboard a11y issues Jan 27, 2016
@bpasero bpasero mentioned this issue Jan 27, 2016
Closed
@bpasero bpasero modified the milestones: Feb 2016, Jan 2016 Jan 28, 2016
@bpasero
Copy link
Member

bpasero commented Jan 28, 2016

We should not use "display: none" but some other CSS property to hide actions (e.g. width). I implemented this for split view actions, but not yet for trees.

@bpasero bpasero closed this as completed in 2c7b1c0 Feb 1, 2016
@bpasero bpasero assigned alexdima and unassigned bpasero Feb 1, 2016
@alexdima alexdima added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
2 participants
@bpasero @alexdima