Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window Actions Overlay Block Editor Actions #232695

Closed
aksalsf opened this issue Oct 31, 2024 · 4 comments · Fixed by #234160
Closed

Window Actions Overlay Block Editor Actions #232695

aksalsf opened this issue Oct 31, 2024 · 4 comments · Fixed by #234160
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@aksalsf
Copy link

aksalsf commented Oct 31, 2024

Type: Bug

  1. Use title bar style 'custom' in Linux
  2. Editor Actions Location: 'Default'
  3. Open vscode in fullscreen mode
  4. Window actions button (minimize, maximize, close) will block editor action buttons

Stable:
Image

Insider:
Image

VS Code version: Code 1.94.2 (384ff73, 2024-10-09T16:08:44.566Z)
OS version: Linux x64 6.9.3-76060903-generic
Modes:

System Info
Item Value
CPUs AMD Ryzen 5 5600G with Radeon Graphics (12 x 4191)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
webnn: disabled_off
Load (avg) 1, 1, 1
Memory (System) 13.54GB (6.32GB free)
Process Argv --crash-reporter-id 82f0f663-7ad6-431d-a7cd-6e2139dd454c --crash-reporter-id 82f0f663-7ad6-431d-a7cd-6e2139dd454c --crash-reporter-id 82f0f663-7ad6-431d-a7cd-6e2139dd454c --crash-reporter-id 82f0f663-7ad6-431d-a7cd-6e2139dd454c --crash-reporter-id 82f0f663-7ad6-431d-a7cd-6e2139dd454c --crash-reporter-id 82f0f663-7ad6-431d-a7cd-6e2139dd454c --crash-reporter-id 82f0f663-7ad6-431d-a7cd-6e2139dd454c --crash-reporter-id 82f0f663-7ad6-431d-a7cd-6e2139dd454c
Screen Reader no
VM 0%
DESKTOP_SESSION pop
XDG_CURRENT_DESKTOP Unity
XDG_SESSION_DESKTOP pop
XDG_SESSION_TYPE x11
Extensions (10)
Extension Author (truncated) Version
vscode-tailwindcss bra 0.12.6
postcss css 1.0.9
vscode-eslint dba 3.0.10
gitlens eam 15.5.1
EditorConfig Edi 0.16.4
copilot Git 1.229.0
headwind hey 1.7.0
material-icon-theme PKi 5.9.0
vscode-conventional-commits viv 1.25.0
material-theme zhu 3.17.2
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
vscaat:30438848
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
9c06g630:31013171
dvdeprecation:31068756
dwnewjupytercf:31046870
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-t:31132770
wkspc-ranged-t:31151552
cf971741:31144450
iacca1:31156133
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013

@aksalsf
Copy link
Author

aksalsf commented Oct 31, 2024

Screencast.from.10-31-2024.11.10.28.AM.webm

@deepak1556 deepak1556 assigned benibenj and unassigned rzhao271 Nov 1, 2024
@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux titlebar VS Code main title bar issues labels Nov 1, 2024
@deepak1556
Copy link
Collaborator

Don't see it as an issue in the runtime, @benibenj can we address this in the application ?

@benibenj benibenj added the important Issue identified as high-priority label Nov 4, 2024
@bpasero bpasero added this to the November 2024 milestone Nov 4, 2024
@bpasero
Copy link
Member

bpasero commented Nov 4, 2024

Maybe we forgot an adoption for Linux via a isWindows check. Will have to investigate.

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Nov 5, 2024
@bpasero
Copy link
Member

bpasero commented Nov 5, 2024

This is a bug in Electron and different from how it works on Windows: electron/electron#44569

@bpasero bpasero added confirmed Issue has been confirmed by VS Code Team member upstream-issue-linked This is an upstream issue that has been reported upstream labels Nov 5, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants