Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: import does not follow .js suffix requirement #228913

Open
bpasero opened this issue Sep 18, 2024 · 1 comment
Open

TS: import does not follow .js suffix requirement #228913

bpasero opened this issue Sep 18, 2024 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues typescript Typescript support issues
Milestone
January 2025

Comments

@bpasero
Copy link
Member

bpasero commented Sep 18, 2024

Steps to Reproduce:

  1. open keybindingsEditor.ts
  2. somewhere use the unmnemonicLabel method
  3. let it auto import

=> 🐛 it adds import { unmnemonicLabel } from '../../../../base/common/labels'; which is not ESM compatible.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues labels Sep 18, 2024
@mjbvz mjbvz added the debt Code quality issues label Dec 10, 2024
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 10, 2024

I'm looking into adopting "moduleResolution": "nodenext" which I think should fix this

Currently blocked by microsoft/vscode-textmate#245

@mjbvz mjbvz added this to the January 2025 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues typescript Typescript support issues
Projects
None yet
Milestone
January 2025
Development

No branches or pull requests
2 participants
@bpasero @mjbvz