Only column breakpoints should show inline bp indicator

[roblourens]

My debug adapters return column locations of BPs, even when a column BP wasn't set. As a result, my code ends up full of bp indicators:

Should we

• only show the column indicators when the user set a column bp
• show the column indicators unless there is only whitespace before that position
• or leave it up to the debug adapter to return a column or not

[chrisdias]

I'm seeing lots of red dots in regular development of a TypeScript based extension. Seems like they appear after I step across a line with multiple statements. Its easy to do, all you need is a for loop and you are in this state.

[isidorn]

After discussing with @weinand we believe that it is best to do what we already specified in the previous milestone in this comment

In short the debug adapter is in charge what breakpoint should he transform into a column brekapoint. Thus an adapter should not add a column to a regular breakpoint if it is not a column breakpoint. Due to this assigning to @roblourens

@chrisdias are you talking about brekapoints or the yellow top stack frame decoration. If you are talking about red brekapoints please file a bug with reproducable steps and file it to me since for that scenario we use node and not node2

[chrisdias]

#22172

[roblourens]

This line: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/electron-browser/debugService.ts#L964 makes it look like the column breakpoints should be ignored already. Is that changing?

[isidorn]

@roblourens my mistake. I was accidently adding a column to a breakpoint when user edits a file.

And yes that line is not supposed to change I just forgot about it. So it is fine for your adapter to return columns if it did not recieve columns.
And the adapter is in charge if it wants to diable column support by potentially always returning column: undefined