Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 2.2 Auto Import and Tslint Formatting #21424

Closed
arciisine opened this issue Feb 25, 2017 · 3 comments
Closed

Typescript 2.2 Auto Import and Tslint Formatting #21424

arciisine opened this issue Feb 25, 2017 · 3 comments
Assignees
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@arciisine
Copy link

arciisine commented Feb 25, 2017

  • VSCode Version:
  • OS Version:

Steps to Reproduce:

  1. Tslint Rules
{
   "rules" : {
       "quotemark" : [
          true,
          "single"
        ]
    }
}
  1. Use the new auto import feature

  2. The import is added with double quotes (instead of single quotes)

The import should be added with matching quotes with respect to tslint.json

@vigie
Copy link

vigie commented Feb 26, 2017

My work around until this is fixed is to use

"tslint.autoFixOnSave": true

@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Feb 28, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 28, 2017

I believe this would be related to #17627, which tracks honoring tslint format settings in general. Also potentially related to microsoft/TypeScript#11320

I've opened microsoft/TypeScript#14347 against TypeScript to track the import quick fix quotes specifically.

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 1, 2017

Closing as tracked upstream by microsoft/TypeScript#13270

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants