Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt sysroot for Linux OSS CI pipeline #212893

Closed
Tracked by #212907
deepak1556 opened this issue May 16, 2024 · 0 comments · Fixed by #212895
Closed
Tracked by #212907

Adopt sysroot for Linux OSS CI pipeline #212893

deepak1556 opened this issue May 16, 2024 · 0 comments · Fixed by #212895
Assignees
@deepak1556
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone
May 2024

Comments

@deepak1556
Copy link
Collaborator

We ran into a situation were it is possible for agents to roll back gcc toolchain which can affect our build if native modules were cached on agents with higher ABI versions. We can reuse the sysroots from product build to avoid any future regressions.

vscode/build/azure-pipelines/linux/product-build-linux.yml

Line 118 in c72bcda

source ./build/azure-pipelines/linux/setup-env.sh

@deepak1556 deepak1556 added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels May 16, 2024
@deepak1556 deepak1556 added this to the May 2024 milestone May 16, 2024
@deepak1556 deepak1556 self-assigned this May 16, 2024
@deepak1556 deepak1556 mentioned this issue May 16, 2024
Merged
@microsoft microsoft deleted a comment from deepak1556 May 16, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 16, 2024
@RIZKYARDIANSYAH25 RIZKYARDIANSYAH25 mentioned this issue May 16, 2024
Closed
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 17, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

ci: use sysroots for oss linux pipeline microsoft/vscode
2 participants
@deepak1556 @vscodenpa