Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Executing large notebooks #210963

Closed
3 of 5 tasks
DonJayamanne opened this issue Apr 22, 2024 · 1 comment
Closed
3 of 5 tasks

Test: Executing large notebooks #210963

DonJayamanne opened this issue Apr 22, 2024 · 1 comment

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Apr 22, 2024

Refs: #209787

Complexity: 3

Create Issue


Pre-requisites

  1. Install the attached VSIX (this is a simple extension that allows extension of notebook cells)
  2. Create a large notebook with at least 500 code cells & 200 markdown cells (the more cells you have the better)
    • Code cells could contain could be print("Hello World")
    • Markdown cells needs to be more complex such as
    # Header 1
    ## Header 2
    ### Header 3
    • Tip:You can create one code cell and one markdown cell, then copy them and paste them a few times.
    • Then copy all cells and copy & paste them
  3. Ensure notebook outline is visible
  4. Enable the setting Notebook: Show Code Cells Symbols
  5. Enable Notebook: Sticky Scroll

Test Steps

  1. Open the notebook
  2. Select the Kernel Dummy Execution
  3. Select the command Dummy Execution: Run all (text output)
  4. Verify the cells run within a few seconds (should be less than 5s)
  5. Tip: You can open the output panel Dummy Execution to see some of the times.
    The entry in the log Time spent in users perspective: n should be low.
    In stable this would be around 10-30 seconds or more, depending on the size of the notebook (cell count).
    Note: the durations displayed in the output panel is in milliseconds
  6. Now run the same steps against VS Code stable and verify its very slow.
    It should be significantly slower than VS Code insiders.
    E.g. if insiders completes in 3s, then stable will take around 30s.
@vscodenpa vscodenpa added this to the April 2024 milestone Apr 22, 2024
@sandy081 sandy081 removed their assignment Apr 23, 2024
@cwebster-99 cwebster-99 removed their assignment Apr 23, 2024
@roblourens
Copy link
Member

I see this take what seems like a very long time

Cells executed 952
Output type text
Time spent in VS Code before extension is notified: 11835
Time spent in Extension Host running all cells: 6498
Time spent in VS Code updating UI after exection completed: 104410
Time spent in users perspective: 122744

@roblourens roblourens removed their assignment Apr 23, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants