Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore removing brackets of language configuration file from the string/regex before evaluating indentation #209862

Closed
aiday-mar opened this issue Apr 8, 2024 · 0 comments · Fixed by #210641
Assignees
Labels
editor-autoindent Editor auto indentation issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@aiday-mar
Copy link
Contributor

aiday-mar commented Apr 8, 2024

In relation to #209519

In the case of a single line string, or a string that appears in conjunction with other tokens on a line, we would like to remove the brackets of the language configuration file from the string, before evaluating the indentation rules on that stripped string. We want to do this to avoid indenting in cases such as the following:

const aString = 'function f() {'

Do the same for brackets inside of the regexes.

@mjbvz mjbvz assigned aiday-mar and unassigned mjbvz Apr 8, 2024
@aiday-mar aiday-mar added editor-autoindent Editor auto indentation issues polish Cleanup and polish issue labels Apr 9, 2024
@aiday-mar aiday-mar changed the title Explore removing brackets of language configuration file from the string before evaluating indentation Explore removing brackets of language configuration file from the string/regex before evaluating indentation Apr 10, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 27, 2024
@vscodenpa vscodenpa added this to the May 2024 milestone May 27, 2024
@aiday-mar aiday-mar added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed feature-request Request for new features or functionality polish Cleanup and polish issue verification-needed Verification of issue is requested labels May 27, 2024
@vscodenpa vscodenpa added on-testplan insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 27, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-autoindent Editor auto indentation issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
3 participants