Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Request: Support for "faded" code #20219

Closed
DustinCampbell opened this issue Feb 8, 2017 · 6 comments
Closed

API Request: Support for "faded" code #20219

DustinCampbell opened this issue Feb 8, 2017 · 6 comments
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone

Comments

@DustinCampbell
Copy link
Member

This a request from the C# for VS Code extension to provide a way for a diagnostic to present itself as "faded" code. Note that this is orthogonal to the squiggle that appears. It's completely expected that a diagnostic could be "faded" while still appearing with a red, green, or no squiggle.

This is needed to support core editing experiences that we have in Visual Studio for code fixes like "Remove Unnecessary Usings", or "Remove Redundant Cast".

fadedusingdirectives

cc @Eilon

@jrieken
Copy link
Member

jrieken commented Feb 15, 2017

@alexandrudima This might be fitting into semantic highlighting?

@DustinCampbell
Copy link
Member Author

Potentially, that's how it's ultimately implemented under the hood in VS as presentation. Logically, we included in the Roslyn diagnostics API. I'll leave it up to you all to figure out how you'd best expose this to VS Code extensions.

@0xdeafcafe
Copy link

Any progress on this?

@jrieken
Copy link
Member

jrieken commented Apr 9, 2018

no progress on this

@rchande
Copy link

rchande commented Jun 13, 2018

@jrieken TypeScript in VS Code now fades unused members--what API do they use to do that? It sounds like that's the same as what's requested here?

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 3, 2018

Addressed by #51104

microsoft/language-server-protocol#500 tracks this for the LSP

@mjbvz mjbvz closed this as completed Jul 3, 2018
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

7 participants