Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support drag and drop between items in the list #200745

Closed
Tyriar opened this issue Dec 13, 2023 · 1 comment · Fixed by #201786
Closed

Support drag and drop between items in the list #200745

Tyriar opened this issue Dec 13, 2023 · 1 comment · Fixed by #201786
Assignees
Labels
feature-request Request for new features or functionality list-widget List widget issues on-testplan

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 13, 2023

@connor4312 suggested in #151284 (comment):

I way I've seen to do this is to have "edges" so that dragging a tab in a small area between two tabs would have a horizontal highlight bar between them, and rearrange. While dragging tab more directly atop another tab highlights the tab itself and will split them.

The problem we're trying to solve here is how to split the terminal groups where the group is presented "inline":

image

We decided at one point that it's confusing when drag and drop splits or unsplits depending on where it's dropped, but some other feature like this could help with this ambiguity. If we do this we should have a chat and decide together about the exact behavior we're planning on.

@Tyriar Tyriar added the list-widget List widget issues label Dec 13, 2023
@benibenj benibenj assigned joaomoreno and unassigned benibenj Dec 13, 2023
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Dec 14, 2023
@joaomoreno joaomoreno added this to the Backlog milestone Dec 14, 2023
@joaomoreno joaomoreno removed their assignment Dec 14, 2023
@benibenj benibenj modified the milestones: Backlog, December / January 2024 Jan 3, 2024
@benibenj benibenj self-assigned this Jan 4, 2024
@benibenj
Copy link
Contributor

benibenj commented Jan 4, 2024

Lists/Trees now support drag and drop between items. This can be tested in the Open Editors View (Supports multi select drag and drop) and in the Debug Watch Expressions View. It's also possible for lists/trees to use DnD between items in some cases and DnD over items in other cases.

@benibenj benibenj closed this as completed Jan 4, 2024
@benibenj benibenj changed the title Support drag and drag between items in the list Support drag and drop between items in the list Jan 4, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality list-widget List widget issues on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@joaomoreno @Tyriar @benibenj @aiday-mar and others