-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree sticky scroll: Consider upping the maximum item count #199540
Comments
So I have not received feature requests for this in the editor. I think the code is less nested generally than in the explorer, where you can easily have a nesting with 10 levels. |
@aiday-mar because of that I think we're bad users to evaluate whether this is needed. The question is, as a user who frequently writes/reads deeply nested code, is it better to take an additional 20+ pixels per row for the proper context showing. Provided we have a decent maximum percentage cap I would guess that the answer will usually be yes, and in the off case where it's no the user can decrease the maximum themselves. |
I was planning on increasing it, but wasn't sure yet what value to pick. 10 seems like a lot even if the user has the space for it. I think I will increase it to around 7/8. I'm also looking into other solutions which would compress multiple nodes into one when the limit is reached, but this won't be part of this release. I think 5 is good for the other two sticky scrolls. |
@benibenj I came up with a similar idea to compress which I think will be even better than increasing the max like that #199539 (comment) |
Should this not be based on screen size rather than a concrete item limit? My screen is a tiny 13" macbook and does not have room for 7/8 |
@lramos15 there's a cap of 40% of screen size regardless of the setting value |
Testing #199153
Related: #199539
The UX degrades quite a bit when the maximum item count is hit. Thinking about the explorer specifically and the maximum 40% height cap, I think it makes sense to increase the maximum to something closer to 10.
Here's my standard explorer setup:
This has plenty of room to include the sticky scroll entries, which not only improve contextual awareness of
ee
, but every file in the view at that time, especially with guides showing:@aiday-mar not sure if you've seen similar feedback for editor? I rarely have code indented that deep fwiw, but that's just my preferred style.
The text was updated successfully, but these errors were encountered: