Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge editor.occurrencesHighlight and editor.multiDocumentOccurrencesHighlight setting #196353

Closed
jrieken opened this issue Oct 24, 2023 · 1 comment · Fixed by #197690
Closed
Assignees
Labels
editor-highlight Editor selection/word highlight issues insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Oct 24, 2023

Testing #196342

There is two settings which is confusing because what should happen when occurrencesHighlight is off but multiDocumentOccurrencesHighlight is on? A better solution would be to change editor.occurrencesHighlight to accept true | false (as today) and a new value set of "off" | "singleFile" | "acrossFiles" (names to be defined)

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Nov 7, 2023

Currently, word based suggestion settings are defined as follows:
image

I can quite easily mirror this approach with:
image

This behave the exact same as before, simply with a more logical setting name and description. In the current approach, with editor.occurrencesHighlight = false and editor.multiDocumentOccurrencesHighlight = true there will be no occurrence highlighting at all.

Effectively, the following two settings json would be equivalent:

  • current:
{
    "editor.occurrencesHighlight": false
    "editor.multiDocumentOccurrencesHighlight": true
}
  • proposed:
{
    "editor.occurrencesHighlight": false,
    "editor.occurrencesHighlightMode": "multiFile"
}

If that works, then it's an easy merge of #197690, Otherwise I can go forward with the other approach of merging the settings into a single entry with multiple value sets.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-highlight Editor selection/word highlight issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants