Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose command to preview/render html #1946

Closed
jrieken opened this issue Jan 12, 2016 · 3 comments
Closed

expose command to preview/render html #1946

jrieken opened this issue Jan 12, 2016 · 3 comments
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jan 12, 2016

We should expose and document our commands to preview/render html from a text document, like preview markdown or render html from doc etc.

@jrieken jrieken added feature-request Request for new features or functionality api labels Jan 12, 2016
@jrieken jrieken self-assigned this Jan 12, 2016
@jrieken jrieken added this to the Jan 2016 milestone Jan 12, 2016
@jrieken
Copy link
Member Author

jrieken commented Jan 12, 2016

@bpasero fyi

@bpasero
Copy link
Member

bpasero commented Jan 12, 2016

👍

I think there is something missing currently to make this work from the workbench. The base input is iFrameEditorInput with subclasses for HTMLFrameEditorInput (which works by showing a URL) and MarkdownEditorInput (which works by just setting the content directly to the iframe).

For this it seems to me we have the content to show as a string (from the code editor model) and we do not have a URL to show.

If we follow a similar model as with ResourceInput, then we can create an input (ResourceFrameEditorInput ?) for the iframe editor that gets its contents from the code editor model that the user provided before hand.

Another thing is how to update the iframe from changes to the code editor model. The input could register to changes on the code editor model and just refresh an opened editor with the input when this happens. This is somewhat we do for markdown today.

@jrieken
Copy link
Member Author

jrieken commented Jan 13, 2016

closing a duplicate of #1308

@jrieken jrieken closed this as completed Jan 18, 2016
@jrieken jrieken added *duplicate Issue identified as a duplicate of another issue(s) and removed *duplicate Issue identified as a duplicate of another issue(s) labels Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants