Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support swiftly fixing quick fix errors one after another #194226

Closed
Tyriar opened this issue Sep 26, 2023 · 5 comments
Closed

Support swiftly fixing quick fix errors one after another #194226

Tyriar opened this issue Sep 26, 2023 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-code-actions Editor inplace actions (Ctrl + .)

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 26, 2023

Testing #194072

Repro:

  1. Create 2 errors on a line
  2. cmd+.
  3. enter
  4. wait a second
  5. cmd+.
  6. enter

Doing this slowly works fine:

Image

Doing it quickly fails:

Image

@justschen
Copy link
Contributor

justschen commented Sep 26, 2023

I've had some folks mention this before as well (not just in the context of this feature) - It's an issue with how the diagnostics are formed. (like how sometimes you hit ctrl + . for the quickfix menu before the error shows up in anticipation of the quickfix being there)

Will do some exploration on how we can optimize this (may be resolved with how I'm handling multiple quickfixes, mentioned in your issue here #194222)

@Tyriar
Copy link
Member Author

Tyriar commented Sep 26, 2023

@justschen the error underline never went away though, so could we be optimistic about this and assume it's still valid if the range for that problem didn't change?

@justschen
Copy link
Contributor

You're right, that's interesting. I'll give it a look 🤔

@justschen justschen added the editor-code-actions Editor inplace actions (Ctrl + .) label Dec 6, 2023
@justschen
Copy link
Contributor

@mjbvz I think this might have something to do with the LSP side of things? I've seen some related issues about errors not being picked up fast enough and people hitting ctrl + . anticipating an error, but the diagnostics have not shown up yet.

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 6, 2023

Yes seems like a duplicate of #117812. Right now we have to manage passing diagnostics to TS Server and these easily get out sync the server

@mjbvz mjbvz closed this as completed Dec 6, 2023
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-code-actions Editor inplace actions (Ctrl + .)
Projects
None yet
Development

No branches or pull requests

3 participants