Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code cannot load extension with prerelease version if earlier, non-prerelease version is installed #19259

Closed
daviwil opened this issue Jan 24, 2017 · 13 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions feature-request Request for new features or functionality
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Jan 24, 2017

  • VSCode Version: VS Code Stable 1.8.1 and VS Code Insiders 1.9.0
  • OS Version: Windows 10 Anniversary

Steps to Reproduce:

  1. Install the PowerShell extension from the Marketplace
  2. Install this VSIX using code --install-extension filename.vsix: https://ci.appveyor.com/api/buildjobs/kqjgav8i2q1nowlq/artifacts/PowerShell-0.9.1-insiders-17.vsix
  3. Start VS Code and open the Extensions pane
  4. Observe that the new extension is recognized but it always shows the "Reload" button:

image

You can also see that this message is in the dev console:

Overwriting extension C:/Users/daviwil/.vscode-insiders/extensions/ms-vscode.PowerShell-0.9.1-insiders-16 with C:/Users/daviwil/.vscode-insiders/extensions/ms-vscode.PowerShell-0.9.0.

If you uninstall both extensions and then only install the "insiders" extension, everything works fine. Maybe the version comparison code for prerelease extensions isn't respecting the greater patch version digit?

@joaomoreno
Copy link
Member

We don't currently support this.

An extension which is installed manually through a VSIX and an extension with the same ID that gets fetch from the gallery are not considered to be the same extension.

We should maybe work towards supporting this, since people expect this to just work. #17290 #15756

@sandy081

@joaomoreno joaomoreno added this to the February 2017 milestone Jan 26, 2017
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Jan 26, 2017
@daviwil
Copy link
Contributor Author

daviwil commented Jan 26, 2017

It'd be really nice if it worked, I want to give my users extension packages straight out of my CI build so they can verify fixes and try new features. The inability to update the extension if an earlier version is installed as VSIX is also a problem, though I understand the concerns that you mentioned on another issue.

I'm trying to avoid having to have an additional "preview" version of the extension on the marketplace just for CI builds but if the team thinks that's the right way to do it then I can do that instead. Thanks!

@jchannon
Copy link

jchannon commented Mar 24, 2017

Would it be possible to load a specific version of an extension eg code -ext [email protected] if you had multiple versions installed. I would really like that option

So it would open the app with the latest versions (pre-release being latest) by default but if you wanted to downgrade you could specify.

The reason I ask this is because the C# plugin at some point will no longer support project.json .net core apps but I have to support a codebase with it in and in production and dont want to update it. I could then choose to install an older version of the plugin which I know supported project.json

@joaomoreno
Copy link
Member

joaomoreno commented Mar 24, 2017

@daviwil Can you still repro this in the latest Insiders? I believe @sandy081 fixed it in #17290.

@jchannon That is another feature request, which likely we won't support. We always delete older versions of extension, in the face of newer ones.

@daviwil
Copy link
Contributor Author

daviwil commented Mar 28, 2017

Sorry for the delay! Just tried this out in today's Insider's update following these steps:

  1. Make sure PowerShell 0.11.0 is installed
  2. Download the VSIX from here and use Extensions: Install from VSIX to install it
  3. Reload VS Code
  4. Prerelease version is not loaded, seems to have maintained the old version (should show 0.11.0-insiders-110):

image

It seems that the extension folder has been unpacked though:

image

@joaomoreno
Copy link
Member

Thanks @daviwil !

@sandy081 You'll check it out?

@joaomoreno joaomoreno modified the milestones: March 2017, April 2017 Mar 28, 2017
@sandy081
Copy link
Member

@joaomoreno Will investigate.

@sandy081 sandy081 modified the milestones: Backlog, April 2017 Apr 25, 2017
@joaomoreno
Copy link
Member

@sandy081 Any updates?

@sandy081
Copy link
Member

@joaomoreno Not yet.. have to look.

@joaomoreno joaomoreno removed their assignment Jun 19, 2017
@sandy081
Copy link
Member

@joaomoreno I think this is because we wont support beta component in version and our semver compare ignores that.

@joaomoreno
Copy link
Member

I know the Marketplace doesn't support it, but we could. 👍

@sandy081
Copy link
Member

This will be taken care by #39024

@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 23, 2017
@vscodebot
Copy link

vscodebot bot commented Nov 23, 2017

This issue has been closed because it is already tracked by another issue. See also our GitHub issues to search for existing issues and our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Nov 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants