Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] Support extending JSON completion #1893

Closed
WebFreak001 opened this issue Jan 9, 2016 · 3 comments
Closed

[json] Support extending JSON completion #1893

WebFreak001 opened this issue Jan 9, 2016 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality json JSON support issues
Milestone

Comments

@WebFreak001
Copy link

Right now there are some hard coded completions like npm or bower versions (https://github.com/Microsoft/vscode/tree/master/src/vs/languages/json/common/contributions)

However it seems it isn't extensible with custom packages, so adding an API for that would be great because I would really like to add support for completing versions in my package

@egamma egamma added the feature-request Request for new features or functionality label Jan 9, 2016
@egamma egamma added this to the Backlog milestone Jan 9, 2016
@egamma
Copy link
Member

egamma commented Jan 9, 2016

Great minds think alike 😄 This is on the plan and we start on it in January, pls see the January iteration plan #1826, in the Debt section.

CC @aeschli

@aeschli aeschli added the json JSON support issues label Jan 11, 2016
@aeschli aeschli changed the title Support extending JSON completion [json] Support extending JSON completion Jan 11, 2016
@WebFreak001
Copy link
Author

Seems like this has been added in vscode 1.1.0

@aeschli aeschli modified the milestones: April 2016, Backlog May 13, 2016
@aeschli
Copy link
Contributor

aeschli commented May 13, 2016

Yes, correct. I forgot to close this issue and comment.
The previously hard coded completions like npm or project.json versions have now moved to the JavaScript resp C# extensions.
Each of these extension registers a completion and hover provider for the corresponding JSON files, and uses the new javac-parser node-module to parse the JSON in order to evaluate the current location in the JSON file.
Have a look at dotnet/vscode-csharp#224 to see how this works.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality json JSON support issues
Projects
None yet
Development

No branches or pull requests

3 participants