Test: Terminal launch and pty host improvements

[Tyriar]

Refs: #186070, #186069, #185396, #185393, #185392, #185391, #185379, #185256, #185254, #130320

• macOS @aiday-mar
• linux @alexr00
• windows @bamurtaugh

Complexity: 3

Authors: @Tyriar, @meganrogge

Create Issue

---

A lot of improvements have happened to how terminals reconnect/revive and how the pty host starts up. This is just a general test, please test at least the following:

• Create several terminals, type in them, reload the window
  • They should reconnect
• Create several terminals, type in them, exit the application and restart
  • They should "revive" with a restored buffer
• Reload twice in quick succession
• Full a terminal's scrollback (eg. ls -lR ~ or tree) and reload
• Anything other edge case you can think of.

If you spot something weird, enable trace logging and capture the Pty Host channel log and the Terminal channel log.

[aiday-mar]

Hi @Tyriar, I am unsure if I am testing wrong, let me know. I opened a VS Code window, the VS Code repo and created three zsh terminals where I typed in each a print statement. I closed the window, opened a VS Code instance with the VS Code repo. From what I understood I should be seeing the print statements from before?

Screen.Recording.2023-06-27.at.11.16.07.mov

I enabled trace logging, and I get the following output under the PTY host output view and in the Terminal output view.

PTY host output before exiting and restarting: pty_host_before.txt

Terminal output before exiting and restarting: terminal_output.txt

PTY host output after exiting and restarting: pty_host_after.txt

Terminal output after exiting and restarting: terminal_output_after.txt

[Tyriar]

@aiday-mar on macOS by exit the application I mean cmd+q to kill the main process, try doing that instead of hitting the red x

[bamurtaugh]

Looks great!

@aiday-mar I'll leave this issue open since I see you're still assigned to it, but please feel free to close if your testing is actually complete (as I see your box is checked in the main issue).

[Tyriar]

Let's close as she's checked off

[aiday-mar]

Hey @Tyriar, I see thanks for the note. Yes it works for me now