Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill all terminals when quit editor #185971

Closed
SilentFlute opened this issue Jun 23, 2023 · 5 comments
Closed

kill all terminals when quit editor #185971

SilentFlute opened this issue Jun 23, 2023 · 5 comments
Assignees
Labels
*as-designed Described behavior is as designed *duplicate Issue identified as a duplicate of another issue(s) terminal-persistence Relating to process reconnection or process revive

Comments

@SilentFlute
Copy link

hi there,
my os is win10, i use git bash as a terminal instead of cmd powershell or sth like that, and i opened multiple vs codewindows(multiple editors), which are different projects of course, one or two maybe more of them launched a git bash, when i pressed "File">"Quit" to quit all editors, i want kill all terminals(even across different windows/editors) and never see them again when i reopen vs code. but now, when i launched vs code again, i saw terminals launched as well, and with some history sessions

so, is that possible?

and i added these two configs to settings.json:

  "terminal.integrated.persistentSessionReviveProcess": "never",
  "terminal.integrated.enablePersistentSessions": false

they just erased the history sessions, but terminals still opened

any solutions are appreciated :)

@meganrogge
Copy link
Contributor

Those settings should work - could you pls provide a gif?

@meganrogge meganrogge added info-needed Issue requires more information from poster terminal-persistence Relating to process reconnection or process revive labels Jun 23, 2023
@SilentFlute
Copy link
Author

here is the version info:

版本: 1.79.2 (user setup)
提交: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
日期: 2023-06-14T08:57:04.379Z
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.19045

and here is a video, i dont know how to create a clear gif, so i used a video instead, hope u dont mind:

btw: the black screen part of the video is when I am restarting the vs code

terminal-persistence.MP4

@meganrogge
Copy link
Contributor

Thanks for the video. When you reload the window, all terminals are killed. We create a new one when the panel is open. If you want to avoid this, then close the panel.

@meganrogge meganrogge added *as-designed Described behavior is as designed and removed info-needed Issue requires more information from poster labels Jun 26, 2023
@SilentFlute
Copy link
Author

thanks for the reply
i dont "reload" the window but "quit" the entire vs code, then i "reopened" it by clicking the shortcut to the vs code in the start menu.
and i totally understand it will create a new terminal if it existed before when i "reload" the window, but the problem is that im exiting and then reopening instead of just reloading
so, is that a misunderstanding or sth?

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2023

/duplicate #39137

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed *duplicate Issue identified as a duplicate of another issue(s) terminal-persistence Relating to process reconnection or process revive
Projects
None yet
Development

No branches or pull requests

4 participants