Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test default additional builtin extension in insiders.vscode.dev #183734

Closed
3 tasks done
sandy081 opened this issue May 29, 2023 · 4 comments
Closed
3 tasks done

Test default additional builtin extension in insiders.vscode.dev #183734

sandy081 opened this issue May 29, 2023 · 4 comments
Assignees
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented May 29, 2023

Refs: #174682

Complexity: 5

Create Issue


This TPI is to test that insiders.vscode.dev will always load latest version for following additional builtin extensions

  • ms-vscode.azure-repos
  • ms-vscode.remote-server
  • GitHub.remotehub
  • GitHub.codespaces
  • ms-vscode.anycode

Make sure when you open insiders.vscode.dev always latest versions of above extensions are loaded. Not only above extensions, their transitive closure dependencies and extension pack extensions are also loaded with latest versions.

  • ms-vscode.remote-repositories extension, dependency of ms-vscode.azure-repos and GitHub.remotehub
  • 9 anycode extensions included in the ms-vscode.anycode extension
  • ms-vscode.remote-explorer extension included in ms-vscode.remote-server and GitHub.codespaces extensions

Try to publish a new version for one of these extensions and make sure this version is loaded in insiders.vscode.dev.

  • ms-vscode.azure-repos (@lszomoru): Test loading dev version of this extension by passing the location using the query param vscode-azurerepos-dev. For example, host this extension locally and pass the location in the URL like below
    https://insiders.vscode.dev/?vscode-azurerepos-dev={location}. This will override the extension that comes from the MP.
  • GitHub.remotehub (@joyceerhl): Test loading dev version of this extension by passing the location using the query param vscode-remotehub-dev. For example, host this extension locally and pass the location in the URL like below
    https://insiders.vscode.dev/?vscode-remotehub-dev={location}. This will override the extension that comes from the MP.

Please NOTE that server has a cache time of 2.5 minutes and MP also has a cache (5~10mins), which means in a worst case, if a new version of extension is published to MP, it might not be available on insiders.vscode.dev for a max of 15 minutes. For all these extensions Update action is never shown even if there is a latest version in Marketplace.

Troubleshoot: In case, the latest version is not loaded, please open Elements tab in dev tools and share the content of the meta element with name vscode:defaultExtensions under head element.

@sandy081 sandy081 added this to the May 2023 milestone May 29, 2023
@sandy081 sandy081 changed the title Test additional builtin extension in insiders.vscode.dev Test default additional builtin extension in insiders.vscode.dev May 29, 2023
@ghost ghost assigned joyceerhl, lszomoru and jrieken May 30, 2023
@joyceerhl
Copy link
Contributor

Test loading dev version of this extension by passing the location using the query param vscode-remotehub-dev. For example, host this extension locally and pass the location in the URL like below

Does this mean it is no longer possible to do Install Extension From Location for an embedder builtin extension like GitHub Repositories?

@joyceerhl joyceerhl removed their assignment May 30, 2023
@joyceerhl
Copy link
Contributor

Latest version loading in insiders.vscode.dev works like a charm 👏

@lszomoru
Copy link
Member

lszomoru commented May 30, 2023

➕ 💯 on automatically loading the latest version 👏🏻

@lszomoru lszomoru removed their assignment May 30, 2023
@sandy081
Copy link
Member Author

Does this mean it is no longer possible to do Install Extension From Location for an embedder builtin extension like GitHub Repositories?

I would say Install Extension From Location is the recommended approach. To clarify, I did not add the support for

Test loading dev version of this extension by passing the location using the query param vscode-azurerepos-dev. For example, host this extension locally and pass the location in the URL like below
https://insiders.vscode.dev/?vscode-azurerepos-dev={location}. This will override the extension that comes from the MP.

This was there before (I do not know who added this) adding this feature and in this TPI I just want to make sure this is not broken with my changes. If no one owns this, I would like to remove this.

CC @lszomoru @joyceerhl

@jrieken jrieken closed this as completed May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants