Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scratchpad editors should not confirm on window close when hotexit = onexit #183378

Closed
amunger opened this issue May 24, 2023 · 2 comments · Fixed by #183473
Closed

scratchpad editors should not confirm on window close when hotexit = onexit #183378

amunger opened this issue May 24, 2023 · 2 comments · Fixed by #183473
Assignees
@amunger
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan workbench-untitled-editors Managing of untitled editors in workbench window
Milestone
June 2023

Comments

@amunger
Copy link
Contributor

amunger commented May 24, 2023 •
edited
Loading

follow up on #174485

we should change the logic to just backup/recover scratchpad working copies when a window is closed, rather than prompting and forcing the user to save/discard.

https://insiders.vscode.dev/github/microsoft/vscode/blob/main/src/vs/workbench/services/workingCopy/electron-sandbox/workingCopyBackupTracker.ts#L151
@amunger amunger self-assigned this May 24, 2023
@amunger amunger added workbench-untitled-editors Managing of untitled editors in workbench window feature-request Request for new features or functionality labels May 24, 2023
@bpasero
Copy link
Member

bpasero commented May 25, 2023

👍 , I think the interesting method to look at is:

vscode/src/vs/workbench/services/workingCopy/electron-sandbox/workingCopyBackupTracker.ts

Line 165 in 51325c0

private async shouldBackupBeforeShutdown(reason: ShutdownReason): Promise<boolean> {

This decides globally based on the hot.exit setting if backups should perform, but then would have to decide on a per-workingcopy basis.

@bpasero bpasero added this to the On Deck milestone May 25, 2023
@amunger amunger mentioned this issue May 25, 2023
Merged
@bpasero bpasero modified the milestones: On Deck, June 2023 May 30, 2023
@bpasero bpasero removed their assignment May 31, 2023
@bpasero
Copy link
Member

bpasero commented May 31, 2023

Feel free to merge in debt week 👍

@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amunger amunger

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan workbench-untitled-editors Managing of untitled editors in workbench window
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

backup scratchpads on window close for hotexit=onexit microsoft/vscode
3 participants
@bpasero @amunger and others