Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-Request: Support specifying alternative tsconfig.json in workspace settings #18140

Closed
fuminchao opened this issue Jan 5, 2017 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues

Comments

@fuminchao
Copy link

fuminchao commented Jan 5, 2017

In our project, we have two tsconfig.json, one for development, one for production.
If we can specify which tsconfig.json to use in the workspace, that would be great

@fuminchao fuminchao changed the title Support specifying alternative tsconfig.json in workspace settings Feature-Request: Support specifying alternative tsconfig.json in workspace settings Jan 5, 2017
@unional
Copy link

unional commented Jan 5, 2017

Current workaround is to use extends:

// tsconfig.json
{
  // Assuming this is your dev setting and want to use it for workspace.
  "extends": "tsconfig.dev.json"
}

@mjbvz mjbvz self-assigned this Jan 5, 2017
@mjbvz mjbvz added javascript JavaScript support issues typescript Typescript support issues labels Jan 5, 2017
@waderyan
Copy link

waderyan commented Jan 5, 2017

@mhegazy I think we've seen this before... I've searched the TS repo and can't find a duplicate. Is this request familiar to you?

@mjbvz mjbvz added the feature-request Request for new features or functionality label Jan 6, 2017
@mhegazy
Copy link

mhegazy commented Jan 10, 2017

There is reference to it in microsoft/TypeScript#11827 and in microsoft/TypeScript#11224. The change would need to be done on the VSCode side as well. you need a gesture to let the user tell you which tsconfig.json to use when opening a folder. we have today an open command for these sorts of cases with OpenExternalProject. we might need to add some other options to make VSCode scenario simpler, but you will need to drive this design proposal.

in general, we believe simplifying the configuration story is better in the long run. Confgurtion inheritance, as noted by @unional erlier, would be the recommended course of action here.

@fuminchao
Copy link
Author

hi all,
Could we just add a configuration like "typescript.tsconfig=xxxxx" in workspace-settings or user-settings?

@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 6, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 6, 2017

I believe this is a duplicate of #12463

@mjbvz mjbvz closed this as completed Apr 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

5 participants