Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide alt text for image outputs #180970

Closed
Tracked by #178630
amunger opened this issue Apr 26, 2023 · 5 comments · Fixed by #182998
Closed
Tracked by #178630

provide alt text for image outputs #180970

amunger opened this issue Apr 26, 2023 · 5 comments · Fixed by #182998
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality notebook-output verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Apr 26, 2023

Is it possible to provide any default alt text for this image element? Currently, it is read as a random data:

1hj50ih7po3rqbhu39heu77llnngjdfil607d24f9urcv5smm9ma/446c9cd2-f4dd-4107-b78a-e8d9b1b46d23

Maybe, "figure" or "cell {index} figure" or possibly the text output as an alt text?

Originally posted by @jooyoungseo in #176293 (comment)

@amunger
Copy link
Contributor Author

amunger commented May 26, 2023

verification steps:

  1. create a notebook with a cell that outputs an image:
import matplotlib.pyplot as plt
plt.plot([1, 2, 3, 4])
plt.ylabel('some numbers')
plt.show()

SVG:

%config InlineBackend.figure_formats = ['svg']

import matplotlib.pyplot as plt
plt.plot([1, 2, 3, 4])
plt.ylabel('some numbers')
plt.show()
  1. ensure the vscode built in renderer is being used (change presentation in the output menu to the left of the output)
  2. a screen reader should read the text output mimetype for the image e.g. '<Figure size 640x480 with 1 Axes>'

@roblourens roblourens added the verified Verification succeeded label May 30, 2023
@roblourens
Copy link
Member

What I see is that it never gets read because it's interrupted by an alert. I am tabbing from the output button into the output, is there something else I should do? It just starts reading it then switches to "Cell 0, the cell output is focused"
Recording 2023-05-30 at 15 41 53

@roblourens
Copy link
Member

Also shouldn't it work with the Jupyter renderer too?

@roblourens roblourens added verification-found Issue verification failed and removed verified Verification succeeded labels May 30, 2023
@roblourens roblourens reopened this May 30, 2023
@amunger
Copy link
Contributor Author

amunger commented May 30, 2023

oh interesting. @rebornix - the aria-alert that I can't get to trigger will interrupt alt-text for the image

@meganrogge meganrogge removed their assignment May 31, 2023
@amunger amunger modified the milestones: May 2023, June 2023 May 31, 2023
@rebornix rebornix modified the milestones: June 2023, July 2023 Jun 26, 2023
@amunger
Copy link
Contributor Author

amunger commented Jun 27, 2023

aria-alert has been removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality notebook-output verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@roblourens @rebornix @amunger @meganrogge @joyceerhl and others