Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff: arrow and breakpoint do not work well together #180789

Closed
bpasero opened this issue Apr 25, 2023 · 4 comments
Closed

Diff: arrow and breakpoint do not work well together #180789

bpasero opened this issue Apr 25, 2023 · 4 comments
Assignees
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Apr 25, 2023

image

Clicking the breakpoint executes the revert action it seems. Looks like click handlers are not yet separate.

@joyceerhl
Copy link
Collaborator

Yeah, I plan to tackle introducing glyph widgets in the margin next iteration, we cannot yet discern the click target. Would it make sense to disable a revert on click when there are multiple decorations for now?

@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Apr 25, 2023
@joyceerhl joyceerhl added this to the April 2023 milestone Apr 25, 2023
@gjsjohnmurray
Copy link
Contributor

See #180986 (comment)

@joyceerhl
Copy link
Collaborator

On second thought, it might be worse to disable a click to revert when there's also a breakpoint, especially since there's no contributed command in the context menu for reverting that can be used as a fallback. I expect to address this by allowing decorations to have dedicated click targets, therefore assigning to May.

@joyceerhl
Copy link
Collaborator

Superseded by #185814

@joyceerhl joyceerhl closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants