Test: glyph margin decoration rendering improvements

[joyceerhl]

Refs: #179725, #5923

• anyOS @isidorn
• anyOS @amunger

Complexity: 3

Authors: @alexdima @joyceerhl

Create Issue

---

This milestone we made improvements to how multiple decorations are rendered in the editor glyph margin (the region to the left of the line numbers where breakpoints appear).

Setup:

• Install a few extensions which will result in decorations being displayed in the glyph margin, e.g.
  • bookmarks extension https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
  • VS Code test selfhost provider extension https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-selfhost-test-provider
  • test coverage provider extension https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters

Test:

1. There should only be one glyph margin lane when a file contains no margin decorations, only debug decorations (e.g. breakpoints, stackframe pointer) or only non-debug decorations (e.g. bookmarks, test decorations, diff revert icon)
   • set a breakpoint in a file and debug it--the breakpoint and stackframe pointer should still appear in the same glyph margin lane
2. If a line in a file has both debug and non-debug decorations (e.g. both testing decorations and breakpoints, or both bookmarks and breakpoints), it should now be possible to see both at a glance
3. If a line in a file has multiple non-debug decorations, the CSS for the decorations is no longer merged, and which decoration appears on top depends on context
   • open a test file from the VS Code repo, set a bookmark on a line that has a test decoration -> the test decoration should win
   • open a diff editor, make a change to a line that has a test decoration -> the diff icon should win

Known limitations:

• You cannot yet click to remove a breakpoint if there is another non-debug decoration on that line (same as stable)
• There isn't yet a way to see overflowed non-debug decorations (same as stable)

[isidorn]

Very cool! Only complaint about the experience is what you already mentioned

You cannot yet click to remove a breakpoint if there is another non-debug decoration on that line (same as stable)

Also I can not click to add a breakpoint, if there is another decoration on the line. This feels like the same, but let me know if you want me to create an issue.